Switch from Addressed-based EU to Acyclic Tx EU

papowerNI commented 2 years ago

[X] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Changes name of Address Based Execution Unit
Also moves some of the naming from Execution Unit Factory into the constructors of the Rx and Tx EUs

Why should this Pull Request be merged?

Just getting some small cosmetic changes out of the way before the more functional changes

What testing has been done?

Built and ran unit/system tests, although this is essentially cosmetic.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Rx Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Rx%20Construct.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Get 1553 Configuration.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Get%201553%20Configuration.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--1553 Address Based Handles to Execution Unit Address Handles.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--1553%20Address%20Based%20Handles%20to%20Execution%20Unit%20Address%20Handles.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--1553 Address Handles to Write Info.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--1553%20Address%20Handles%20to%20Write%20Info.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--1553 Channels to Address Based Handles.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--1553%20Channels%20to%20Address%20Based%20Handles.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--Address Based Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--Address%20Based%20Construct.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--Initialize.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--Initialize.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--Write to Hardware.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Tx Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Tx%20Construct.vi.png)

Create Execution Unit.lvclass--test BC Only.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-01/16%3A58%3A16/Create%20Execution%20Unit.lvclass--test%20BC%20Only.vi.png)

The following VIs could not be diffed:

C:\jenkins\workspace\m-milStd1553-custom-device_PR-47\Source\Custom Device Support\Engine\Implementation\Address Based Execution Unit\Get Bus Controller and Remote Terminals Handles from BTI Channel.vi

buckd commented 2 years ago

Are you planning on moving the files on disk to Tx Acyclic Execution Unit instead of Address Based Execution Unit as part of this PR or a different PR?

papowerNI commented 2 years ago

Are you planning on moving the files on disk to Tx Acyclic Execution Unit instead of Address Based Execution Unit as part of this PR or a different PR?

I should do it in this PR, looks like I just missed that

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Rx Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Rx%20Construct.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Get 1553 Configuration.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Get%201553%20Configuration.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--1553 Address Based Handles to Execution Unit Address Handles.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--1553%20Address%20Based%20Handles%20to%20Execution%20Unit%20Address%20Handles.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--1553 Address Handles to Write Info.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--1553%20Address%20Handles%20to%20Write%20Info.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--1553 Channels to Address Based Handles.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--1553%20Channels%20to%20Address%20Based%20Handles.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--Address Based Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--Address%20Based%20Construct.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--Initialize.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--Initialize.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--Write to Hardware.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Tx Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Tx%20Construct.vi.png)

Create Execution Unit.lvclass--test BC Only.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A18%3A25/Create%20Execution%20Unit.lvclass--test%20BC%20Only.vi.png)

The following VIs could not be diffed:

C:\jenkins\workspace\m-milStd1553-custom-device_PR-47\Source\Custom Device Support\Engine\Implementation\Address Based Execution Unit\Get Bus Controller and Remote Terminals Handles from BTI Channel.vi

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A46%3A06/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Rx Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A46%3A06/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Rx%20Construct.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Get 1553 Configuration.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A46%3A06/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Get%201553%20Configuration.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--1553 Address Handles to Write Info.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A46%3A06/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--1553%20Address%20Handles%20to%20Write%20Info.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Acyclic Execution Unit.lvclass--1553 Channels to Address Based Handles.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A46%3A06/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Acyclic%20Execution%20Unit.lvclass--1553%20Channels%20to%20Address%20Based%20Handles.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Tx Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A46%3A06/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Tx%20Construct.vi.png)

Create Execution Unit.lvclass--test BC Only.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-47/2022-07-06/10%3A46%3A06/Create%20Execution%20Unit.lvclass--test%20BC%20Only.vi.png)

ni / niveristand-aim-milStd1553-custom-device