ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Re-write and massively re-use code for Create Execution Unit tests #58

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

Why should this Pull Request be merged?

Enable the Create Execution Unit tests

What testing has been done?

I ran all of the tests and used results to get the terminal, channel, and message counts. I verified these values against looking at the system definition produced in each case.

Note about Expected Messages in the RT-only case: This makes sense, as it is not finding MC 01. This is a message not received by any terminal in the file because it is a BC to RT message with no corresponding RT, so nothing about it gets persisted in the system definition file.

Expected vs. found channels/messages ![image](https://user-images.githubusercontent.com/31290917/179291115-27dca9b7-bd9d-4317-a5e0-16135a37299a.png)
VI Tester results ![image](https://user-images.githubusercontent.com/31290917/179291156-0a605675-1601-4739-9aa6-20eaaef16608.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Check Execution Unit Channel Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-14/17%3A50%3A35/Check%20Execution%20Unit%20Channel%20Count.vi.png)
Create Execution Unit.lvclass--Check Expected Terminal and Message Counts.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-14/17%3A50%3A35/Create%20Execution%20Unit.lvclass--Check%20Expected%20Terminal%20and%20Message%20Counts.vi.png)
Create Execution Unit.lvclass--Check Rx Execution Unit Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-14/17%3A50%3A35/Create%20Execution%20Unit.lvclass--Check%20Rx%20Execution%20Unit%20Message%20Count.vi.png)
Create Execution Unit.lvclass--Check Tx Async Execution Unit Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-14/17%3A50%3A35/Create%20Execution%20Unit.lvclass--Check%20Tx%20Async%20Execution%20Unit%20Message%20Count.vi.png)
Create Execution Unit.lvclass--Check Tx Execution Unit Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-14/17%3A50%3A35/Create%20Execution%20Unit.lvclass--Check%20Tx%20Execution%20Unit%20Message%20Count.vi.png)
Create Execution Unit.lvclass--Run Execution Unit Count Checks.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-14/17%3A50%3A35/Create%20Execution%20Unit.lvclass--Run%20Execution%20Unit%20Count%20Checks.vi.png)
Create Execution Unit.lvclass--test BC + RTs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-14/17%3A50%3A35/Create%20Execution%20Unit.lvclass--test%20BC%20%2B%20RTs.vi.png)
Create Execution Unit.lvclass--test BC Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-14/17%3A50%3A35/Create%20Execution%20Unit.lvclass--test%20BC%20Only.vi.png)
Create Execution Unit.lvclass--test RTs Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-14/17%3A50%3A35/Create%20Execution%20Unit.lvclass--test%20RTs%20Only.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Find All Acyclic Frames.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/09%3A18%3A51/AIM%20MIL-STD-1553%20Scripting.lvlib--Find%20All%20Acyclic%20Frames.vi.png)
Create Execution Unit.lvclass--Check Execution Unit Channel Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/09%3A18%3A51/Create%20Execution%20Unit.lvclass--Check%20Execution%20Unit%20Channel%20Count.vi.png)
Create Execution Unit.lvclass--Check Expected Terminal and Message Counts.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/09%3A18%3A51/Create%20Execution%20Unit.lvclass--Check%20Expected%20Terminal%20and%20Message%20Counts.vi.png)
Create Execution Unit.lvclass--Check Rx Execution Unit Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/09%3A18%3A51/Create%20Execution%20Unit.lvclass--Check%20Rx%20Execution%20Unit%20Message%20Count.vi.png)
Create Execution Unit.lvclass--Check Tx Async Execution Unit Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/09%3A18%3A51/Create%20Execution%20Unit.lvclass--Check%20Tx%20Async%20Execution%20Unit%20Message%20Count.vi.png)
Create Execution Unit.lvclass--Check Tx Execution Unit Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/09%3A18%3A51/Create%20Execution%20Unit.lvclass--Check%20Tx%20Execution%20Unit%20Message%20Count.vi.png)
Create Execution Unit.lvclass--Run Execution Unit Count Checks.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/09%3A18%3A51/Create%20Execution%20Unit.lvclass--Run%20Execution%20Unit%20Count%20Checks.vi.png)
Create Execution Unit.lvclass--test BC + RTs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/09%3A18%3A51/Create%20Execution%20Unit.lvclass--test%20BC%20%2B%20RTs.vi.png)
Create Execution Unit.lvclass--test BC Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/09%3A18%3A51/Create%20Execution%20Unit.lvclass--test%20BC%20Only.vi.png)
Create Execution Unit.lvclass--test RTs Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/09%3A18%3A51/Create%20Execution%20Unit.lvclass--test%20RTs%20Only.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Find All Acyclic Frames.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/12%3A16%3A25/AIM%20MIL-STD-1553%20Scripting.lvlib--Find%20All%20Acyclic%20Frames.vi.png)
Create Execution Unit.lvclass--Check Execution Unit Channel Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/12%3A16%3A25/Create%20Execution%20Unit.lvclass--Check%20Execution%20Unit%20Channel%20Count.vi.png)
Create Execution Unit.lvclass--Check Expected Terminal and Message Counts.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/12%3A16%3A25/Create%20Execution%20Unit.lvclass--Check%20Expected%20Terminal%20and%20Message%20Counts.vi.png)
Create Execution Unit.lvclass--Check Rx Execution Unit Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/12%3A16%3A25/Create%20Execution%20Unit.lvclass--Check%20Rx%20Execution%20Unit%20Message%20Count.vi.png)
Create Execution Unit.lvclass--Check Tx Async Execution Unit Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/12%3A16%3A25/Create%20Execution%20Unit.lvclass--Check%20Tx%20Async%20Execution%20Unit%20Message%20Count.vi.png)
Create Execution Unit.lvclass--Check Tx Execution Unit Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/12%3A16%3A25/Create%20Execution%20Unit.lvclass--Check%20Tx%20Execution%20Unit%20Message%20Count.vi.png)
Create Execution Unit.lvclass--Run Execution Unit Count Checks.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/12%3A16%3A25/Create%20Execution%20Unit.lvclass--Run%20Execution%20Unit%20Count%20Checks.vi.png)
Create Execution Unit.lvclass--test BC + RTs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/12%3A16%3A25/Create%20Execution%20Unit.lvclass--test%20BC%20%2B%20RTs.vi.png)
Create Execution Unit.lvclass--test BC Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/12%3A16%3A25/Create%20Execution%20Unit.lvclass--test%20BC%20Only.vi.png)
Create Execution Unit.lvclass--test RTs Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-58/2022-07-15/12%3A16%3A25/Create%20Execution%20Unit.lvclass--test%20RTs%20Only.vi.png)