search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Persist string properties as human-readable strings #64

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

Persist string properties as human-readable strings

Why should this Pull Request be merged?

Some strings are being saved as binary strings. This makes reading the system definition file difficult.

What testing has been done?

Ran all automated tests

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Set Acyclic Frame in Trigger.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-64/2022-07-15/15%3A44%3A50/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Acyclic%20Frame%20in%20Trigger.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Set Logging Directory.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-64/2022-07-15/15%3A44%3A50/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Logging%20Directory.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Set Logging File Name.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-64/2022-07-15/15%3A44%3A50/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Logging%20File%20Name.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Set Message Name.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-64/2022-07-15/15%3A44%3A50/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Message%20Name.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Set Message Type.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-64/2022-07-15/15%3A44%3A50/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Message%20Type.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Set Acyclic Frame in Trigger.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-64/2022-07-15/16%3A53%3A10/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Acyclic%20Frame%20in%20Trigger.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Set Logging Directory.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-64/2022-07-15/16%3A53%3A10/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Logging%20Directory.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Set Logging File Name.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-64/2022-07-15/16%3A53%3A10/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Logging%20File%20Name.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Set Message Name.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-64/2022-07-15/16%3A53%3A10/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Message%20Name.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Set Message Type.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-64/2022-07-15/16%3A53%3A10/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Message%20Type.vi.png)