ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Remove Logging section from Custom Device until implemented #68

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

Why should this Pull Request be merged?

Like terminal status channels in #61, this removes placeholder custom device functionality that will not be completed for the first release. Rather than let users access a Logging section in System Explorer that does nothing, this removes the section from the custom device by default.

This does not remove Logging from the palette/scripting API. It also doesn't look for less invasive options like just updating the System Explorer to say 'Not implemented yet'. I'm happy to discuss those options, but I wanted to mock up removal if that is the desired route.

What testing has been done?

Executed system tests

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-15/17%3A50%3A32/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Logging Execution Unit.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-15/17%3A50%3A32/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Logging%20Execution%20Unit.lvclass--Initialize.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Create Shared Resources.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-15/17%3A50%3A32/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Create%20Shared%20Resources.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Find Logging Section.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-15/17%3A50%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Find%20Logging%20Section.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Initialize Custom Device.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-15/17%3A50%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Initialize%20Custom%20Device.vi.png)
Logging Loopback.lvclass--setUp.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-15/17%3A50%3A32/Logging%20Loopback.lvclass--setUp.vi.png)
Logging Loopback.lvclass--tearDown.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-15/17%3A50%3A32/Logging%20Loopback.lvclass--tearDown.vi.png)
Scripting.lvclass--test Get-Set Logging Properties.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-15/17%3A50%3A32/Scripting.lvclass--test%20Get-Set%20Logging%20Properties.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/09%3A15%3A44/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Logging Execution Unit.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/09%3A15%3A44/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Logging%20Execution%20Unit.lvclass--Initialize.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Create Shared Resources.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/09%3A15%3A44/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Create%20Shared%20Resources.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Find Logging Section.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/09%3A15%3A44/AIM%20MIL-STD-1553%20Scripting.lvlib--Find%20Logging%20Section.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Initialize Custom Device.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/09%3A15%3A44/AIM%20MIL-STD-1553%20Scripting.lvlib--Initialize%20Custom%20Device.vi.png)
Logging Loopback.lvclass--setUp.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/09%3A15%3A44/Logging%20Loopback.lvclass--setUp.vi.png)
Logging Loopback.lvclass--tearDown.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/09%3A15%3A44/Logging%20Loopback.lvclass--tearDown.vi.png)
Scripting.lvclass--test Get-Set Logging Properties.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/09%3A15%3A44/Scripting.lvclass--test%20Get-Set%20Logging%20Properties.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/11%3A15%3A08/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Create Shared Resources.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/11%3A15%3A08/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Create%20Shared%20Resources.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Find Logging Section.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/11%3A15%3A08/AIM%20MIL-STD-1553%20Scripting.lvlib--Find%20Logging%20Section.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Initialize Custom Device.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/11%3A15%3A08/AIM%20MIL-STD-1553%20Scripting.lvlib--Initialize%20Custom%20Device.vi.png)
Logging Loopback.lvclass--setUp.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/11%3A15%3A08/Logging%20Loopback.lvclass--setUp.vi.png)
Logging Loopback.lvclass--tearDown.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/11%3A15%3A08/Logging%20Loopback.lvclass--tearDown.vi.png)
Scripting.lvclass--test Get-Set Logging Properties.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-68/2022-07-18/11%3A15%3A08/Scripting.lvclass--test%20Get-Set%20Logging%20Properties.vi.png)
Karl-G1 commented 2 years ago

We decided to leave the Logging section in place and update the System Explorer page to document that it is not yet supported. I'll abandon this PR and put up those changes separately.