search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

change tx acyclic to trigger #69

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Since Tx Acyclic Execution Unit doesn't actually contain anything except the triggers, and the Acyclic Tx buffer updates are actually performed in the Tx Execution Unit along with cyclic transmissions, it can be renamed to triggers for clarity.

Why should this Pull Request be merged?

This should make the execution unit a little more explicit for any future development.

What testing has been done?

Fully ATS passes. This is also cosmetic, no functional changes: image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-69/2022-07-18/11%3A44%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Get VS Channel Handles and Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-69/2022-07-18/11%3A44%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Get%20VS%20Channel%20Handles%20and%20Messages.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-69/2022-07-18/11%3A44%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Initialize.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Read Triggerable Frames.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-69/2022-07-18/11%3A44%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Read%20Triggerable%20Frames.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Triggers Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-69/2022-07-18/11%3A44%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Triggers%20Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Write to Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-69/2022-07-18/11%3A44%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)
Create Execution Unit.lvclass--Check Tx Async Execution Unit Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-69/2022-07-18/11%3A44%3A46/Create%20Execution%20Unit.lvclass--Check%20Tx%20Async%20Execution%20Unit%20Message%20Count.vi.png)