search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Change trigger search method #73

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Prior to this change, triggers only searched Transmitted Messages for matching messages in triggerable frames, which does not work if the bus simulation interacts with RTs that are not within this custom device. This changes the triggerable frames search to look in all messages and ignore duplicates.

Why should this Pull Request be merged?

If this is not added, some configurations of BC only or RT only with external hardware will not properly trigger.

What testing has been done?

Manual testing results, with Ballard RTs and AIM BC: bc to rt

Automated testing results: image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Get VS Channel Handles and Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-73/2022-07-20/10%3A22%3A07/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Get%20VS%20Channel%20Handles%20and%20Messages.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Populate Triggerable Frames with Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-73/2022-07-20/10%3A22%3A07/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Populate%20Triggerable%20Frames%20with%20Messages.vi.png)
papowerNI commented 2 years ago

Some debugging code is still in the VIs

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Get VS Channel Handles and Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-73/2022-07-20/11%3A21%3A39/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Get%20VS%20Channel%20Handles%20and%20Messages.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Populate Triggerable Frames with Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-73/2022-07-20/11%3A21%3A39/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Populate%20Triggerable%20Frames%20with%20Messages.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Get VS Channel Handles and Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-73/2022-07-20/12%3A21%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Get%20VS%20Channel%20Handles%20and%20Messages.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Populate Triggerable Frames with Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-73/2022-07-20/12%3A21%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Populate%20Triggerable%20Frames%20with%20Messages.vi.png)