ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Use configuration file for hardware parameters in system tests #77

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

Why should this Pull Request be merged?

Fixes #66 Enable developers to override the PXI configuration (card number, BIU number, etc.) without modifying test VIs. This stores hardware parameters in Shared/Config.ini like each test class's targets.ini stores the hostname.

What testing has been done?

Ran automated tests image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Deployment.lvclass--setUp.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-77/2022-07-28/15%3A24%3A49/Deployment.lvclass--setUp.vi.png)
Deployment.lvclass--test Deployment Import BC-Only Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-77/2022-07-28/15%3A24%3A49/Deployment.lvclass--test%20Deployment%20Import%20BC-Only%20Configuration.vi.png)
Deployment.lvclass--test Deployment Import Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-77/2022-07-28/15%3A24%3A49/Deployment.lvclass--test%20Deployment%20Import%20Configuration.vi.png)
Deployment.lvclass--test Deployment Import RT-Only Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-77/2022-07-28/15%3A24%3A49/Deployment.lvclass--test%20Deployment%20Import%20RT-Only%20Configuration.vi.png)
Loopback.lvclass--globalSetUp.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-77/2022-07-28/15%3A24%3A49/Loopback.lvclass--globalSetUp.vi.png)
Karl-G1 commented 2 years ago
  • [ ] I haven't run the tests since I don't want to interfere with other development and don't have a 1553 target, but Loopback:globalSetUp.vi seems like it's probably not using the correct config file path. The settings in the Create and Script 1553 System Definition.vi match what is in the config file, so it is likely silently being ignored. This needs to point to the Shared directory. image

That sub VI should already return a path to Shared/Assets, so that logic should work. Using an invalid config file path should return error 7.

buckd commented 2 years ago

That sub VI should already return a path to Shared/Assets, so that logic should work. Using an invalid config file path should return error 7.

I didn't realize that scripting VI being in Shared would have that consequence.