Closed Karl-G1 closed 2 years ago
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
- [ ] I haven't run the tests since I don't want to interfere with other development and don't have a 1553 target, but
Loopback:globalSetUp.vi
seems like it's probably not using the correct config file path. The settings in theCreate and Script 1553 System Definition.vi
match what is in the config file, so it is likely silently being ignored. This needs to point to theShared
directory.
That sub VI should already return a path to Shared/Assets, so that logic should work. Using an invalid config file path should return error 7.
That sub VI should already return a path to Shared/Assets, so that logic should work. Using an invalid config file path should return error 7.
I didn't realize that scripting VI being in Shared
would have that consequence.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
Fixes #66 Enable developers to override the PXI configuration (card number, BIU number, etc.) without modifying test VIs. This stores hardware parameters in
Shared/Config.ini
like each test class's targets.ini stores the hostname.What testing has been done?
Ran automated tests