Add start stop behavior

papowerNI commented 2 years ago

[X] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Add start/stop controls and engine behavior in the Triggers Execution Unit
Add running status that communicates start/stop state of each terminal
Add system test for start stop testing

Why should this Pull Request be merged?

Starting and stopping BC or RTs is part of the second AIM 1553 release.

What testing has been done?

ATS passes:

I also manually tested the start/stop behavior and it worked as expected with manual testing (when Stopped, RT/BC stops doing things).

papowerNI commented 2 years ago

[x] Still need to run the ATS tests once hardware issues are sorted.

Also, timestamps do not stop when the terminal is stopped. This could be accomplished by moving the start/stop behavior into the Rx Execution Unit, but it would require adding Write to Hardware to the Rx Execution Unit as well, which would behave inline.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Filter Messages by Direction.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Filter%20Messages%20by%20Direction.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Get All Compiled Messages and Subaddresses.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Get%20All%20Compiled%20Messages%20and%20Subaddresses.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Read Terminal Addresses.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Read%20Terminal%20Addresses.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Read Minor Frame Period.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Read%20Minor%20Frame%20Period.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Get Start and Stop VS Channel Handles for Terminals.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Get%20Start%20and%20Stop%20VS%20Channel%20Handles%20for%20Terminals.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Initialize.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Initialize.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Read from Hardware.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Read%20from%20Hardware.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Start or Stop Terminals.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Start%20or%20Stop%20Terminals.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Triggers Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Triggers%20Construct.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Write to Hardware.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)

AIM MIL-STD-1553 Hardware API.lvlib--Disable RT.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Disable%20RT.vi.png)

AIM MIL-STD-1553 Hardware API.lvlib--Enable RT.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Enable%20RT.vi.png)

AIM MIL-STD-1553 Hardware API.lvlib--Start Bus Controller.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Start%20Bus%20Controller.vi.png)

AIM MIL-STD-1553 Hardware API.lvlib--Stop Bus Controller.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Stop%20Bus%20Controller.vi.png)

AIM MIL-STD-1553 Scripting.lvlib--Add Bus Controller.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Bus%20Controller.vi.png)

AIM MIL-STD-1553 Scripting.lvlib--Add Remote Terminal.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Remote%20Terminal.vi.png)

AIM MIL-STD-1553 Scripting.lvlib--Add Terminal Status Channel.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Terminal%20Status%20Channel.vi.png)

Create Execution Unit.lvclass--test Get VS Channel Handles and Messages.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/Create%20Execution%20Unit.lvclass--test%20Get%20VS%20Channel%20Handles%20and%20Messages.vi.png)

Loopback.lvclass--test Timestamps with Start and Stop Command.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/03%3A07%3A56/Loopback.lvclass--test%20Timestamps%20with%20Start%20and%20Stop%20Command.vi.png)

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Filter Messages by Direction.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Filter%20Messages%20by%20Direction.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Get All Compiled Messages and Subaddresses.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Get%20All%20Compiled%20Messages%20and%20Subaddresses.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Read Terminal Addresses.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Read%20Terminal%20Addresses.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Read Minor Frame Period.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Read%20Minor%20Frame%20Period.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Get Start and Stop VS Channel Handles for Terminals.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Get%20Start%20and%20Stop%20VS%20Channel%20Handles%20for%20Terminals.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Initialize.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Initialize.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Read from Hardware.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Read%20from%20Hardware.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Start or Stop Terminals.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Start%20or%20Stop%20Terminals.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Triggers Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Triggers%20Construct.vi.png)

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Triggers Execution Unit.lvclass--Write to Hardware.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Triggers%20Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)

AIM MIL-STD-1553 Hardware API.lvlib--Disable RT.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Disable%20RT.vi.png)

AIM MIL-STD-1553 Hardware API.lvlib--Enable RT.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Enable%20RT.vi.png)

AIM MIL-STD-1553 Hardware API.lvlib--Start Bus Controller.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Start%20Bus%20Controller.vi.png)

AIM MIL-STD-1553 Hardware API.lvlib--Stop Bus Controller.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Stop%20Bus%20Controller.vi.png)

AIM MIL-STD-1553 Scripting.lvlib--Add Bus Controller.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Bus%20Controller.vi.png)

AIM MIL-STD-1553 Scripting.lvlib--Add Remote Terminal.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Remote%20Terminal.vi.png)

AIM MIL-STD-1553 Scripting.lvlib--Add Terminal Status Channel.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Terminal%20Status%20Channel.vi.png)

Create Execution Unit.lvclass--test BC + RTs.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/Create%20Execution%20Unit.lvclass--test%20BC%20%2B%20RTs.vi.png)

Create Execution Unit.lvclass--test BC Only.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/Create%20Execution%20Unit.lvclass--test%20BC%20Only.vi.png)

Create Execution Unit.lvclass--test Get VS Channel Handles and Messages.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/Create%20Execution%20Unit.lvclass--test%20Get%20VS%20Channel%20Handles%20and%20Messages.vi.png)

Create Execution Unit.lvclass--test RTs Only.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/Create%20Execution%20Unit.lvclass--test%20RTs%20Only.vi.png)

Loopback.lvclass--test Timestamps with Start and Stop Command.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-80/2022-08-04/12%3A41%3A01/Loopback.lvclass--test%20Timestamps%20with%20Start%20and%20Stop%20Command.vi.png)

papowerNI commented 2 years ago

Fixes #60

ni / niveristand-aim-milStd1553-custom-device