ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

override static buffer index #83

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Why should this Pull Request be merged?

Useful for customers who might want to control the indices of buffers needed on each BIU in their system.

What testing has been done?

All automated tests passed. Also added a Print Debug Line to the Read Buffer.vi call and verified that if is specified, the specified value is used instead of the default value.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

1553 Parameters Import.lvclass--test Import Error when No Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/1553%20Parameters%20Import.lvclass--test%20Import%20Error%20when%20No%20Channels.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Create Shared Resources.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Create%20Shared%20Resources.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Hardware.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Read Buffer.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Read%20Buffer.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Add Starting Buffer Index.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Starting%20Buffer%20Index.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Constants.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Read BIU Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Read%20BIU%20Configuration.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Read Starting Buffer Index.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Read%20Starting%20Buffer%20Index.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Write BIU Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Write%20BIU%20Configuration.vi.png)
MIL-STD 1553 Import.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/MIL-STD%201553%20Import.lvlib--Constants.vi.png)
MIL-STD 1553 Import.lvlib--Parse Parameters File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/MIL-STD%201553%20Import.lvlib--Parse%20Parameters%20File.vi.png)
Refresh.lvclass--test Diff Configuration (Add Remove Ports and Acyclic Frame).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/Refresh.lvclass--test%20Diff%20Configuration%20(Add%20Remove%20Ports%20and%20Acyclic%20Frame).vi.png)
Refresh.lvclass--test Diff Configuration (Add Remove RTs).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/Refresh.lvclass--test%20Diff%20Configuration%20(Add%20Remove%20RTs).vi.png)
Refresh.lvclass--test Diff Configuration (Modify Add Remove).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/Refresh.lvclass--test%20Diff%20Configuration%20(Modify%20Add%20Remove).vi.png)
Refresh.lvclass--test Diff Configuration (No Change).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/Refresh.lvclass--test%20Diff%20Configuration%20(No%20Change).vi.png)
Scripting.lvclass--test Add-Find-Remove Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/Scripting.lvclass--test%20Add-Find-Remove%20Messages.vi.png)
Scripting.lvclass--test Get-Set-Get Parameter Definitions.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/Scripting.lvclass--test%20Get-Set-Get%20Parameter%20Definitions.vi.png)
Scripting.lvclass--test Read-Write BIU Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/Scripting.lvclass--test%20Read-Write%20BIU%20Configuration.vi.png)
Scripting.lvclass--test Script CD with Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/Scripting.lvclass--test%20Script%20CD%20with%20Configuration.vi.png)
Scripting.lvclass--test Verify No Timestamp Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/Scripting.lvclass--test%20Verify%20No%20Timestamp%20Channels.vi.png)
Scripting.lvclass--test Verify Timestamp Channels Created.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/11%3A55%3A32/Scripting.lvclass--test%20Verify%20Timestamp%20Channels%20Created.vi.png)
Karl-G1 commented 2 years ago

This new attribute is not displayed in the Refresh dialog. @Karl-G1, is it important that this be displayed when refreshing a parameters file?

This would be nice to have, but not required. Since we are going to update the Refresh dialog for major/minor/acyclic frames and their contents, perhaps we can make those optional changes later.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

1553 Parameters Import.lvclass--test Import Error when No Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/1553%20Parameters%20Import.lvclass--test%20Import%20Error%20when%20No%20Channels.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Create Shared Resources.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Create%20Shared%20Resources.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Hardware.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Add Starting Buffer Index.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Starting%20Buffer%20Index.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/AIM%20MIL-STD-1553%20Scripting.lvlib--Constants.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Read BIU Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/AIM%20MIL-STD-1553%20Scripting.lvlib--Read%20BIU%20Configuration.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Read Starting Buffer Index.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/AIM%20MIL-STD-1553%20Scripting.lvlib--Read%20Starting%20Buffer%20Index.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Write BIU Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/AIM%20MIL-STD-1553%20Scripting.lvlib--Write%20BIU%20Configuration.vi.png)
MIL-STD 1553 Import.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/MIL-STD%201553%20Import.lvlib--Constants.vi.png)
MIL-STD 1553 Import.lvlib--Parse Parameters File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/MIL-STD%201553%20Import.lvlib--Parse%20Parameters%20File.vi.png)
Refresh.lvclass--test Diff Configuration (Add Remove Ports and Acyclic Frame).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/Refresh.lvclass--test%20Diff%20Configuration%20(Add%20Remove%20Ports%20and%20Acyclic%20Frame).vi.png)
Refresh.lvclass--test Diff Configuration (Add Remove RTs).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/Refresh.lvclass--test%20Diff%20Configuration%20(Add%20Remove%20RTs).vi.png)
Refresh.lvclass--test Diff Configuration (Modify Add Remove).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/Refresh.lvclass--test%20Diff%20Configuration%20(Modify%20Add%20Remove).vi.png)
Refresh.lvclass--test Diff Configuration (No Change).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/Refresh.lvclass--test%20Diff%20Configuration%20(No%20Change).vi.png)
Scripting.lvclass--test Add-Find-Remove Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/Scripting.lvclass--test%20Add-Find-Remove%20Messages.vi.png)
Scripting.lvclass--test Get-Set-Get Parameter Definitions.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/Scripting.lvclass--test%20Get-Set-Get%20Parameter%20Definitions.vi.png)
Scripting.lvclass--test Read-Write BIU Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/Scripting.lvclass--test%20Read-Write%20BIU%20Configuration.vi.png)
Scripting.lvclass--test Script CD with Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/Scripting.lvclass--test%20Script%20CD%20with%20Configuration.vi.png)
Scripting.lvclass--test Verify No Timestamp Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/Scripting.lvclass--test%20Verify%20No%20Timestamp%20Channels.vi.png)
Scripting.lvclass--test Verify Timestamp Channels Created.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-83/2022-08-09/16%3A25%3A21/Scripting.lvclass--test%20Verify%20Timestamp%20Channels%20Created.vi.png)