search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Add bus status section and tests #84

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Why should this Pull Request be merged?

Status channels are a desired feature for AIM 1553 second release, and these are the channels that are available.

What testing has been done?

Manually observed working status channels image

image

Automated tests are all passing: image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Filter Messages by Direction.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Filter%20Messages%20by%20Direction.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Read from Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Read%20from%20Hardware.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Finalize Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Finalize%20Hardware.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Hardware.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Check Status.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Check%20Status.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Start All.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Start%20All.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Stop All.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Stop%20All.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Add Bus Status Section with Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Bus%20Status%20Section%20with%20Channels.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Scripting.lvlib--Constants.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Get Bus Status Channel Names.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Scripting.lvlib--Get%20Bus%20Status%20Channel%20Names.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Get Bus Status Section and Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Scripting.lvlib--Get%20Bus%20Status%20Section%20and%20Channels.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Initialize Custom Device.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20Scripting.lvlib--Initialize%20Custom%20Device.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Bus Status Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Bus%20Status%20Count.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Bus Status Load.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Bus%20Status%20Load.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Bus Status Section.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Bus%20Status%20Section.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Build Map from Page GUIDs to Page VIs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Build%20Map%20from%20Page%20GUIDs%20to%20Page%20VIs.vi.png)
Create Execution Unit.lvclass--test BC + RTs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/Create%20Execution%20Unit.lvclass--test%20BC%20%2B%20RTs.vi.png)
Create Execution Unit.lvclass--test BC Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/Create%20Execution%20Unit.lvclass--test%20BC%20Only.vi.png)
Create Execution Unit.lvclass--test RTs Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/Create%20Execution%20Unit.lvclass--test%20RTs%20Only.vi.png)
Loopback.lvclass--test Loopback Check Status.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/Loopback.lvclass--test%20Loopback%20Check%20Status.vi.png)
Scripting.lvclass--test Add-Get Bus Status Section.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-11/12%3A54%3A46/Scripting.lvclass--test%20Add-Get%20Bus%20Status%20Section.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Filter Messages by Direction.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Filter%20Messages%20by%20Direction.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Read from Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Read%20from%20Hardware.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Hardware.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Check Status.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Check%20Status.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Start All.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Start%20All.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Stop All.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Stop%20All.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Add Bus Status Section with Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Bus%20Status%20Section%20with%20Channels.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Scripting.lvlib--Constants.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Get Bus Status Channel Names.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Scripting.lvlib--Get%20Bus%20Status%20Channel%20Names.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Get Bus Status Section and Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Scripting.lvlib--Get%20Bus%20Status%20Section%20and%20Channels.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Initialize Custom Device.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20Scripting.lvlib--Initialize%20Custom%20Device.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Bus Status Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Bus%20Status%20Count.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Bus Status Load.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Bus%20Status%20Load.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Bus Status Section.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Bus%20Status%20Section.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Build Map from Page GUIDs to Page VIs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Build%20Map%20from%20Page%20GUIDs%20to%20Page%20VIs.vi.png)
Create Execution Unit.lvclass--test BC + RTs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/Create%20Execution%20Unit.lvclass--test%20BC%20%2B%20RTs.vi.png)
Create Execution Unit.lvclass--test BC Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/Create%20Execution%20Unit.lvclass--test%20BC%20Only.vi.png)
Create Execution Unit.lvclass--test RTs Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/Create%20Execution%20Unit.lvclass--test%20RTs%20Only.vi.png)
Loopback.lvclass--test Loopback Check Status.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/Loopback.lvclass--test%20Loopback%20Check%20Status.vi.png)
Scripting.lvclass--test Add-Get Bus Status Section.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-84/2022-08-12/01%3A23%3A47/Scripting.lvclass--test%20Add-Get%20Bus%20Status%20Section.vi.png)