various performance improvements

[papowerNI]

• [X] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

• Remove duplicate Read Module Reference
• Remove unnecessary data manipulation during encode/decode in Read from HW and Write to Hardware
• Remove Hardware Disable in Send Acyclic Frames and Write to Hardware since they are in-loop (can add it back if needed for future testing)
• Skip adding a Shared Resources map entry for a frame if the frame has no contents

Why should this Pull Request be merged?

Performance is improved (a parameters file with 240 messages with 1 word each is used):

What testing has been done?

Automated tests continue to pass:

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

1553 Parameters Import.lvclass--test Import Acyclic Frames.vi.png


1553 Parameters Import.lvclass--test Import Major and Minor Frames.vi.png


1553 Parameters Import.lvclass--test Import Messages.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Logging Execution Unit.lvclass--Finalize.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Decode Words to Parameters.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Read from Hardware.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Get 1553 Configuration.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Encode Parameters to Words.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Write to Hardware.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Configure Major Frame.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Create BC Transfer and Buffer.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Disable RT.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Read Bus Monitor Entries.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Send Acyclic Frames.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Update Buffer Words.vi.png


MIL-STD 1553 Import.lvlib--Read Acyclic Frames.vi.png


MIL-STD 1553 Import.lvlib--Read Major Frames.vi.png


MIL-STD 1553 Import.lvlib--Read Minor Frames.vi.png


[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

1553 Parameters Import.lvclass--test Import Acyclic Frames.vi.png


1553 Parameters Import.lvclass--test Import Major and Minor Frames.vi.png


1553 Parameters Import.lvclass--test Import Messages.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Logging Execution Unit.lvclass--Finalize.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Decode Words to Parameters.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Read from Hardware.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Get 1553 Configuration.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Encode Parameters to Words.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Write to Hardware.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Configure Major Frame.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Create BC Transfer and Buffer.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Read Bus Monitor Entries.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Send Acyclic Frames.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Update Buffer Words.vi.png


MIL-STD 1553 Import.lvlib--Read Acyclic Frames.vi.png


MIL-STD 1553 Import.lvlib--Read Major Frames.vi.png


MIL-STD 1553 Import.lvlib--Read Minor Frames.vi.png


[papowerNI]

• [x] Configure Major Frame.vi has no changes.

I did move an item on the block diagram so that it isn't pushed up against a case structure that got resized in previous PRs

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

1553 Parameters Import.lvclass--test Import Acyclic Frames.vi.png


1553 Parameters Import.lvclass--test Import Major and Minor Frames.vi.png


1553 Parameters Import.lvclass--test Import Messages.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Decode Words to Parameters.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Read from Hardware.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Get 1553 Configuration.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Encode Parameters to Words.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Write to Hardware.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Configure Major Frame.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Create BC Transfer and Buffer.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Read Bus Monitor Entries.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Send Acyclic Frames.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Update Buffer Words.vi.png


MIL-STD 1553 Import.lvlib--Read Acyclic Frames.vi.png


MIL-STD 1553 Import.lvlib--Read Major Frames.vi.png


MIL-STD 1553 Import.lvlib--Read Minor Frames.vi.png


[papowerNI]

Fixes #62