search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Add optional Asynchronous Rx Execution Unit running capability #92

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Adds a boolean option to the custom device to run the Rx Execution Unit asynchronously instead of inline.

Why should this Pull Request be merged?

This can increase the performance of other inline custom devices and hardware calls in the case where AIM 1553 Rx calls are slowing down the PCL.

What testing has been done?

Tried with the Run Rx Asynchronously boolean set to true and false, and observed that the execution time is not placed on the PCL when set to true: image

Also checked that automated tests are passing, including added test: image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-92/2022-09-01/12%3A24%3A53/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-92/2022-09-01/12%3A24%3A53/AIM%20MIL-STD-1553%20Scripting.lvlib--Constants.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Get Run Rx Asynchronously.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-92/2022-09-01/12%3A24%3A53/AIM%20MIL-STD-1553%20Scripting.lvlib--Get%20Run%20Rx%20Asynchronously.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Set Run Rx Asynchronously.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-92/2022-09-01/12%3A24%3A53/AIM%20MIL-STD-1553%20Scripting.lvlib--Set%20Run%20Rx%20Asynchronously.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Main Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-92/2022-09-01/12%3A24%3A53/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Main%20Page.vi.png)
Create Execution Unit.lvclass--test Run Rx Asynchronously.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-92/2022-09-01/12%3A24%3A53/Create%20Execution%20Unit.lvclass--test%20Run%20Rx%20Asynchronously.vi.png)