search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Fix Start Stop overwritten by Execution Monitor #95

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Currently the last start/stop RT will be overwritten by the execution monitor data if execution monitor is disabled. This will fix that issue.

Why should this Pull Request be merged?

Data is being overwritten.

What testing has been done?

Added to the Start Stop test, it passes: image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Timing Channel Array.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-95/2022-09-02/14%3A05%3A13/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Timing%20Channel%20Array.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Write Execution Time.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-95/2022-09-02/14%3A05%3A13/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Write%20Execution%20Time.vi.png)
Loopback.lvclass--test Timestamps with Start and Stop Command.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-95/2022-09-02/14%3A05%3A13/Loopback.lvclass--test%20Timestamps%20with%20Start%20and%20Stop%20Command.vi.png)