search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Buffer updates on parameter import #96

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

Buffers System Explorer updates when importing parameters files to drastically improve import time.

Why should this Pull Request be merged?

This is a similar change to ones for the other custom devices based off the comms bus template. As in those cases, it reduces the time it takes to import large config files. With the attached config files (which isn't really that big), import goes from ~12 seconds to ~1 second. Parameters - Big.zip

What testing has been done?

Ran automated unit tests to verify they still pass. Manually tested system explorer import behavior.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Write BIU Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-96/2022-09-02/17%3A36%3A13/AIM%20MIL-STD-1553%20Scripting.lvlib--Write%20BIU%20Configuration.vi.png)