ni / niveristand-ballard-arinc429-custom-device

Custom device for Ballard ARINC 429 hardware
MIT License
5 stars 5 forks source link

Remove ability to create 'special' channels on Tx HW Channels #74

Closed Karl-G1 closed 3 years ago

Karl-G1 commented 3 years ago

Describe the bug Importing a parameters XML file with the following tags on Tx HW Channels should not be allowed.

<createSDIChannel>true</createSDIChannel>
<createSSMChannel>true</createSSMChannel>
<createParityChannel>true</createParityChannel>

Currently, these channels are a mix of harmless and breaking:

To Reproduce Steps to reproduce the behavior:

  1. Import the parameter file attached here.
  2. See the additional VS channels created.

1ch 5label 4param all encoding extra channels_HW_Core_0.zip

Expected behavior A Parameters XML file with those tags on Tx HW Channels should either throw an error or simply do not add the SDI, SSM, or Parity VS channels.

Additional context We could optionally turn these VeriStand channels into controls (outputs) to allow the user to override the values either set or calculated for the actual bits sent with the label. However, during our discussion on this topic, it was decided to remove the ability to create the channels for Tx HW Channels. If needed, that decision can be re-evaluated in the future.

Karl-G1 commented 3 years ago

Note we should also update this in the schema that all three tags are for Rx HW Channels when we make the change.

dbendele commented 3 years ago

82 modifies import such that special channels for SDI, SSM, Parity do not get added for Tx.