search

ni / niveristand-ballard-milStd1553-custom-device

Custom device for Ballard MIL-STD-1553 hardware
MIT License
2 stars 4 forks source link

Buffer updates on parameter import #213

Closed buckd closed 2 years ago

buckd commented 2 years ago

What does this Pull Request accomplish?

Buffers System Explorer updates when importing parameters files to drastically improve import time.

Why should this Pull Request be merged?

Without this change, redrawing the tree for the parameters file at Source/Custom Device Support/Tests/System/Loopback/Assets/1553_VS_Scaled_Parameters.xml takes about 6 seconds. With this change, it is 1 second.

What testing has been done?

Ran automated tests to verify they still pass. Manually timed import to verify faster import/redraw. Verified there are no weird tree artifacts where items are drawn in the wrong location.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Ballard MIL-STD-1553 Scripting.lvlib--Write Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-213/2022-04-25/12%3A57%3A50/Ballard%20MIL-STD-1553%20Scripting.lvlib--Write%20Configuration.vi.png)