Implement Timing Channels in Engine

Karl-G1 commented 2 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Create mechanism for storing the Incoming Channel index offset and current execution time per execution unit to report execution duration to the appropriate timing channel
- Add accessors to the Execution Unit implementation for Timing Offset and Current Execution Time
- Add methods and overrides to the Execution Unit interface and implementation for Update Current Execution Time and Write Execution Time
- Set the offset to a non-negative (valid) value when creating each execution unit
- Use the offset to replace the array element of the incoming channel data array per execution unit
Create two new sub VIs for use in the engine (Timed Read from Hardware and Timed Write to Hardware)
- These call into the respective existing VIs and use the microsecond tick count VI to calculate execution time
- Because the Write VI does not modify the incoming data, store the Current Execution Time
- In the Read VI, add its duration and the current execution time, then update the value in the data array
Add system test to deploy with Timing Channels section added

Why should this Pull Request be merged?

Give users an optional set of timing channels to analyze per-execution unit execution duration to determine custom device performance implications on their system.

What testing has been done?

Deployed with various system configurations to see execution time change as expected
Ran test suite

Karl-G1 commented 2 years ago

Running into problems while running all of the system tests together. Will investigate tomorrow.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Create Timing Channel Array.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Create%20Timing%20Channel%20Array.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Execution Unit.Async.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Execution%20Unit.Async.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Read from Inline Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Read%20from%20Inline%20Execution%20Units.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Timed Read from Hardware.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Timed%20Read%20from%20Hardware.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Timed Write to Hardware.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Timed%20Write%20to%20Hardware.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Write to Inline Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Write%20to%20Inline%20Execution%20Units.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Address Based Execution Unit.lvclass--Address Based Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Address%20Based%20Execution%20Unit.lvclass--Address%20Based%20Construct.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Read current execution time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Read%20current%20execution%20time.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Read timing channel offset.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Read%20timing%20channel%20offset.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Update Current Execution Time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Update%20Current%20Execution%20Time.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Write current execution time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Write%20current%20execution%20time.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Write Execution Time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Write%20Execution%20Time.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Write timing channel offset.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Write%20timing%20channel%20offset.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Logging Execution Unit.lvclass--Logging Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Logging%20Execution%20Unit.lvclass--Logging%20Construct.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Rx Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Rx%20Construct.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Tx Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Tx%20Construct.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Interfaces.lvlib--Execution Unit.lvclass--Update Current Execution Time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Interfaces.lvlib--Execution%20Unit.lvclass--Update%20Current%20Execution%20Time.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Interfaces.lvlib--Execution Unit.lvclass--Write Execution Time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Ballard%20MIL-STD-1553%20Engine.lvlib--Interfaces.lvlib--Execution%20Unit.lvclass--Write%20Execution%20Time.vi.png)

Deployment.lvclass--test Deployment Timing Channels.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-07/19%3A26%3A17/Deployment.lvclass--test%20Deployment%20Timing%20Channels.vi.png)

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Create Timing Channel Array.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Create%20Timing%20Channel%20Array.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Execution Unit.Async.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Execution%20Unit.Async.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Read from Inline Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Read%20from%20Inline%20Execution%20Units.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Timed Read from Hardware.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Timed%20Read%20from%20Hardware.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Timed Write to Hardware.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Timed%20Write%20to%20Hardware.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Write to Inline Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Write%20to%20Inline%20Execution%20Units.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Address Based Execution Unit.lvclass--Address Based Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Address%20Based%20Execution%20Unit.lvclass--Address%20Based%20Construct.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Read current execution time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Read%20current%20execution%20time.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Read timing channel offset.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Read%20timing%20channel%20offset.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Update Current Execution Time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Update%20Current%20Execution%20Time.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Write current execution time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Write%20current%20execution%20time.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Write Execution Time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Write%20Execution%20Time.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Write timing channel offset.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Write%20timing%20channel%20offset.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Logging Execution Unit.lvclass--Logging Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Logging%20Execution%20Unit.lvclass--Logging%20Construct.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Rx Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Rx%20Construct.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Tx Construct.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Tx%20Construct.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Interfaces.lvlib--Execution Unit.lvclass--Update Current Execution Time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Interfaces.lvlib--Execution%20Unit.lvclass--Update%20Current%20Execution%20Time.vi.png)

Ballard MIL-STD-1553 Engine.lvlib--Interfaces.lvlib--Execution Unit.lvclass--Write Execution Time.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Ballard%20MIL-STD-1553%20Engine.lvlib--Interfaces.lvlib--Execution%20Unit.lvclass--Write%20Execution%20Time.vi.png)

Deployment.lvclass--test Deployment Timing Channels.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-ballard-milStd1553-custom-device/PR-221/2022-09-08/11%3A00%3A16/Deployment.lvclass--test%20Deployment%20Timing%20Channels.vi.png)

ni / niveristand-ballard-milStd1553-custom-device