ni / niveristand-ballard-milStd1553-custom-device

Custom device for Ballard MIL-STD-1553 hardware
MIT License
2 stars 4 forks source link

use a different value than 0 for terminalAddress element in the parameter XML file to identify BusController #225

Closed fmussi closed 1 year ago

fmussi commented 2 years ago

The parameter xml file uses a remoteTerminal value of 0 to identify the Bus Controller.

There could be configurations where terminalAddress 0 has to be associated to a specific Remote Terminal. I would suggest to use a different value for the BC in the XML parameter file, that stays outside the range defined by the 1553 protocol, e.g. -1 or 32

bariskarkar commented 1 year ago

I need to simulate RT0. Can you solve the problem?

papowerNI commented 1 year ago

@bariskarkar @fmussi We are working on adding this to the 1553 custom device currently, does the following revised parameter file make sense to you? A false would exclude the bus controller, and the additional property allows us to free up RT0 for use.

?xml version="1.0"?>
<parameters xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
    <version>1.1</version>
    <channel>
        <hardwareChannel>0</hardwareChannel>
        <busController>
            <simulate>True</simulate>
            <name>MyBusController</name> (optional)
        </busController>
        <terminals>
            <terminal>
                <terminalAddress>0</terminalAddress>
            </terminal>
            <terminal>
                <terminalAddress>1</terminalAddress>
            </terminal>
            <terminal>
                <terminalAddress>15</terminalAddress>
            </terminal>
        </terminals>
bariskarkar commented 1 year ago

I think it makes sense. Thus, as in the protocol, we do not need to assign any terminal addresses for the BC.

bariskarkar commented 1 year ago

Hello @papowerNI, thank you for your support. The documents have been updated but no release has been published yet. This causes differences between the current version of the documents and the last release. Can you publish a new release with the updated version?

Karl-G1 commented 1 year ago

@bariskarkar We are finishing testing on the changes @papowerNI made over the last few weeks, then we will post a release tag with packaged builds. Should be soon.

Karl-G1 commented 1 year ago

@bariskarkar Release 23.3 was just posted with fixes added and documented over the last couple of weeks.