search

ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Update GUID constant name for custom device #108

Closed buckd closed 3 years ago

buckd commented 3 years ago

What does this Pull Request accomplish?

Renames the GUID constant used for the custom device from GUID.Communication Bus Template to GUID.Custom Device.

Why should this Pull Request be merged?

When a user creates a new copy of the template, they are not going to keep the GUID name of Communication Bus Template. This means every user of the template is going to have to go in and change this name. While a user may still want to customize this name, using Custom Device is more generic and would not necessarily require changing the name.

What testing has been done?

Replaced all instances and built the custom device. Verified successful deployment and traces in the event viewer.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Scripting.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-108/2021-07-14/15%3A08%3A55/Communication%20Bus%20Template%20Scripting.lvlib--Constants.vi.png)
Communication Bus Template Scripting.lvlib--Get Database List of Names and Paths.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-108/2021-07-14/15%3A08%3A55/Communication%20Bus%20Template%20Scripting.lvlib--Get%20Database%20List%20of%20Names%20and%20Paths.vi.png)
Communication Bus Template System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Get Menu Item VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-108/2021-07-14/15%3A08%3A55/Communication%20Bus%20Template%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Get%20Menu%20Item%20VI.vi.png)
Communication Bus Template System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Get Menu Items.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-108/2021-07-14/15%3A08%3A55/Communication%20Bus%20Template%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Get%20Menu%20Items.vi.png)
Communication Bus Template System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Get Page VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-108/2021-07-14/15%3A08%3A55/Communication%20Bus%20Template%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Get%20Page%20VI.vi.png)