Fix crash when PPLs in virtual folders are replaced

buckd commented 3 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Move PPLs out of the Includes virtual folder during cloning to avoid crash when the PPLs are replaced.

Why should this Pull Request be merged?

LabVIEW fairly consistently crashes when the PPLs inside the virtual folder are replaced. This change prevents that crash.

What testing has been done?

Ran the template tool multiple times and did not see a crash. Previously crashed 4 out of 5 times.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Template Tool.lvlib--Clone Template Main.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-114/2021-08-09/15%3A42%3A17/Template%20Tool.lvlib--Clone%20Template%20Main.vi.png)

Template Tool.lvlib--Reparent Included PPLs.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-114/2021-08-09/15%3A42%3A17/Template%20Tool.lvlib--Reparent%20Included%20PPLs.vi.png)

Template Tool.lvlib--Replace Project PPLs.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-114/2021-08-09/15%3A42%3A17/Template%20Tool.lvlib--Replace%20Project%20PPLs.vi.png)

buckd commented 3 years ago

Do you need to close the Project Item references? Or is calling Delete sufficient?

Delete closes the reference, although I do need close the My Computer ref.

buckd commented 3 years ago

although I do need close the My Computer ref.

Actually, I don't have to do this because Project.Close closes all other refs for project items.

ni / niveristand-communications-bus-template