search

ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Provide a stub implementation of the execution unit interface #12

Closed rtzoeller closed 4 years ago

rtzoeller commented 4 years ago

What does this Pull Request accomplish?

Provide a stub implementation of the execution unit and execution unit factory interfaces. These currently just log to the system event log when they are called.

Why should this Pull Request be merged?

We need to be able to implement these interfaces eventually, and having a stub implementation now lets us sort out things like PPL loading in the engine and evaluate the interface design more critically.

What testing has been done?

Confirmed that I can deploy the custom device and that the system event log gets populated with messages from the custom device.

rtzoeller commented 4 years ago

@buckd trying to figure out the build changes here... it seems like dependencies are copied based on the existence of the dependency_target key, but here we effectively have two different dependency steps: the execution unit implementation depends on the interface PPL, and the custom device depends on both PPLs. Not sure how to make that work with the current build tools implementation.

rtzoeller commented 4 years ago

Confirmed with @niphilj and @buckd that we are okay merging the PPLs for now.

rtzoeller commented 4 years ago

I've consolidated the PPLs into a single project, but left the file structure intact for now. Let me know if we should consolidate the files more than they are now.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Communication Bus Template Interfaces.lvlib--Execution Unit.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Interfaces.lvlib--Execution%20Unit.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Factory Implementation.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Factory%20Implementation.lvclass--Create%20Execution%20Unit.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Construct.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Finalize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Finalize.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Get Identifier.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Get%20Identifier.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Initialize.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Read from Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Read%20from%20Hardware.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Start.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Start.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Trace.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Trace.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Write to Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Write%20to%20Hardware.vi.png)
Communication Bus Template System Explorer.lvlib--ActionVIOnCompile.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-16/08%3A48%3A36/Communication%20Bus%20Template%20System%20Explorer.lvlib--ActionVIOnCompile.vi.png)
niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Communication Bus Template Interfaces.lvlib--Execution Unit.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Interfaces.lvlib--Execution%20Unit.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Factory Implementation.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Factory%20Implementation.lvclass--Create%20Execution%20Unit.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Construct.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Finalize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Finalize.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Get Identifier.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Get%20Identifier.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Initialize.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Read from Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Read%20from%20Hardware.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Start.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Start.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Trace.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Trace.vi.png)
Communication Bus Template Interfaces.lvlib--Protocol Implementation.lvlib--Execution Unit Implementation.lvclass--Write to Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20Interfaces.lvlib--Protocol%20Implementation.lvlib--Execution%20Unit%20Implementation.lvclass--Write%20to%20Hardware.vi.png)
Communication Bus Template System Explorer.lvlib--ActionVIOnCompile.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-12/2020-09-17/14%3A38%3A55/Communication%20Bus%20Template%20System%20Explorer.lvlib--ActionVIOnCompile.vi.png)