ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Disable tracing based on project conditional disable symbol #127

Closed dbendele closed 2 years ago

dbendele commented 2 years ago

Describe the bug As a template user, it is really frustrating when there are debugging elements in the template that wind up being the focus of a debugging/diagnostics effort. In this case, @Karl-G1 noted performance issues (max rate limited to 100 Hz) when testing the Ballard MIL-STD-1553 custom device.

To Reproduce Steps to reproduce the behavior in an instantiated custom device:

  1. Increase the loop rate to 1 kHz.
  2. Deploy the system definition.
  3. Take note of the actual loop rate.
  4. Actual loop rate topped out at 100 Hz for the 1553 custom device before tracing was conditionally disabled. Furthermore, the actual loop rate showed regular drops to 50 Hz.

Expected behavior I expect the custom devices generated from this template to be able to achieve some healthy percentage of the theoretical maximum for the supported protocol.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context https://github.com/ni/niveristand-ballard-milStd1553-custom-device/pull/157