search

ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Uniquify execution unit names to enable multiple instance of custom device to run in parallel #128

Closed dbendele closed 2 years ago

dbendele commented 2 years ago

Describe the bug When developing the Ballard ARINC 429 and the Ballard MIL-STD-1553 custom devices, it was frustrating to debug issues blocking parallel execution. A small change to the template in the Create Execution Unit VI would avoid this issue.

To Reproduce Steps to reproduce the behavior:

  1. Include two instances of the custom device in the VeriStand project.
  2. Deploy and verify loopback.

Expected behavior Custom devices that allow multiple instances should work with multiple instances.

Screenshots reference https://github.com/ni/niveristand-ballard-milStd1553-custom-device/issues/174

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

buckd commented 2 years ago

It looks like we can probably fix this by prepending the CD name to the channel group names in Compile Asynchronous Execution Units.vi. That should prevent the loopback problem, but it probably still makes sense to create unique names for the execution units as well, for logging/tracing purposes during debugging.