ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

update Write to Hardware.vi to include valid triggers input #130

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Fixes #129

Why should this Pull Request be merged?

Fixing the template in response to a fix that was needed in the Ballard ARINC-429 Custom Device. This fix should help avoid identical issues in other devices generated from this template.

What testing has been done?

This identical change was demonstrated to fix the issue in the Ballard device, see https://github.com/ni/niveristand-ballard-arinc429-custom-device/pull/200

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Execution Unit.Async.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-130/2022-02-16/15%3A02%3A09/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Execution%20Unit.Async.vi.png)
Communication Bus Template Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Write to Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-130/2022-02-16/15%3A02%3A09/Communication%20Bus%20Template%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)
Communication Bus Template Engine.lvlib--Interfaces.lvlib--Execution Unit.lvclass--Write to Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-130/2022-02-16/15%3A02%3A09/Communication%20Bus%20Template%20Engine.lvlib--Interfaces.lvlib--Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Execution Unit.Async.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-130/2022-02-18/15%3A30%3A56/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Execution%20Unit.Async.vi.png)
Communication Bus Template Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Write to Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-130/2022-02-18/15%3A30%3A56/Communication%20Bus%20Template%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)
Communication Bus Template Engine.lvlib--Interfaces.lvlib--Execution Unit.lvclass--Write to Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-130/2022-02-18/15%3A30%3A56/Communication%20Bus%20Template%20Engine.lvlib--Interfaces.lvlib--Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)