search

ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Simplify build spec names #133

Closed buckd closed 2 years ago

buckd commented 2 years ago

What does this Pull Request accomplish?

Changes the build spec names in the support project to not have "Communication Bus" prepended to Engine and System Explorer.

Why should this Pull Request be merged?

These build spec names are not modified by the cloning tool, so even after creating a fresh instance, "Communication Bus" is still in the build spec names and all the custom devices we have created from this template have removed that extra text from the build spec names and modified the build.toml. This change eliminates these extra steps.

What testing has been done?

Ran the template cloning tool and verified everything is correctly generated and builds. PR build confirms build.toml changes are good.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Template Tool.lvlib--Build Support lvproj PPLs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-133/2022-02-28/16%3A01%3A01/Template%20Tool.lvlib--Build%20Support%20lvproj%20PPLs.vi.png)
Template Tool.lvlib--Update Support Build Specs and Build.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-133/2022-02-28/16%3A01%3A01/Template%20Tool.lvlib--Update%20Support%20Build%20Specs%20and%20Build.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Template Tool.lvlib--Build Support lvproj PPLs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-133/2022-03-01/08%3A30%3A55/Template%20Tool.lvlib--Build%20Support%20lvproj%20PPLs.vi.png)
Template Tool.lvlib--Update Support Build Specs and Build.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-133/2022-03-01/08%3A30%3A55/Template%20Tool.lvlib--Update%20Support%20Build%20Specs%20and%20Build.vi.png)