search

ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Use RTM Wrapper instead of individual wrapper VIs #136

Closed Karl-G1 closed 2 years ago

Karl-G1 commented 2 years ago

What does this Pull Request accomplish?

Why should this Pull Request be merged?

This is purely tech debt reduction. The end behavior should be identical.

I recently added RTM entries in two custom devices using the wrapper VI approach. When going to implement the same logic here, I realized we have a way of avoiding that built into the template but unused by the CDs we've built from the template.

What testing has been done?

Built all build specs and tested behavior in System Explorer

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template System Explorer.lvlib--Implementation.lvlib--EnableDisable RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-136/2022-07-06/15%3A33%3A51/Communication%20Bus%20Template%20System%20Explorer.lvlib--Implementation.lvlib--EnableDisable%20RTM.vi.png)
Communication Bus Template System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Get Menu Item VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-136/2022-07-06/15%3A33%3A51/Communication%20Bus%20Template%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Get%20Menu%20Item%20VI.vi.png)
Communication Bus Template System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Get Menu Items.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-136/2022-07-06/15%3A33%3A51/Communication%20Bus%20Template%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Get%20Menu%20Items.vi.png)
EnableDisable RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-136/2022-07-06/15%3A33%3A51/EnableDisable%20RTM.vi.png)
Export Configuration RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-136/2022-07-06/15%3A33%3A51/Export%20Configuration%20RTM.vi.png)
Import Configuration RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-136/2022-07-06/15%3A33%3A51/Import%20Configuration%20RTM.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template System Explorer.lvlib--Implementation.lvlib--EnableDisable RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-136/2022-07-06/15%3A55%3A37/Communication%20Bus%20Template%20System%20Explorer.lvlib--Implementation.lvlib--EnableDisable%20RTM.vi.png)
Communication Bus Template System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Get Menu Item VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-136/2022-07-06/15%3A55%3A37/Communication%20Bus%20Template%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Get%20Menu%20Item%20VI.vi.png)
Communication Bus Template System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Get Menu Items.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-136/2022-07-06/15%3A55%3A37/Communication%20Bus%20Template%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Get%20Menu%20Items.vi.png)