Closed Karl-G1 closed 2 years ago
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
highlight
parameter on Add Timing Section.vi
. Do we have precedent for this elsewhere?
- [ ] Not sure how I feel about the
highlight
parameter onAdd Timing Section.vi
. Do we have precedent for this elsewhere?
I was staying consistent with other VIs in the scripting API like Add Ports Section.vi
and Add Databases Section
. However, I haven't seen them implemented with a highlight input on the actual CDs we branched from the template.
That's fine then.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
I was looking for a way to implement Dynamic menu items like you can specify in the Custom Device XML. Because the RTM Wrapper is already building a custom menu item, I extended the wrapper VIs to allow programmatic disabling of menu items. From there, two things were needed: 1) the ability to call scripting VIs in the Dispatcher class and 2) remove the 'first call' logic to dynamically rebuild the menu items each time the page is loaded.
As an example of these changes, I started implementing support for the "timing channels" recently added to the ARINC 429 Custom Devices. These were implemented with 4x RTM VIs (2 in support, 2 in CD) and a new section in the CD XML. This approach lets the CD Project and CD XML stay relatively uncoupled with the RTM implementation.
What testing has been done?
Manually test the RTM items in System Explorer.