ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Build the scripting API for template #15

Closed buckd closed 4 years ago

buckd commented 4 years ago

What does this Pull Request accomplish?

Configures the build spec for scripting API and builds an nipkg for distributing the API.

Why should this Pull Request be merged?

The template repo should contain everything needed for getting started with the template. This includes build specs and automated build scripts.

What testing has been done?

API build spec builds with no error. Waiting on PR build for testing of nipkg.

buckd commented 4 years ago

The scripting package does not depend on ni-veristand-custom-device-labview-support-common because that package currently only lives in the Routing and Faulting repo. If we want to use that palette for other scripting APIs, we need to find a different place for it (maybe the developer tools repo?)

rtzoeller commented 4 years ago

@buckd I think we could put it in the virtual package repo or create another standalone repo.

I don't see why we couldn't depend on it now, even though it's sourced from another repo. The dependency is install-time, not build-time.

buckd commented 4 years ago

I don't see why we couldn't depend on it now, even though it's sourced from another repo. The dependency is install-time, not build-time.

The only reason I'm hesitant right now is if we plan on distributing nipkgs to users for evaluation, they now have to install stuff from a completely separate repo before using it. Although, now that I'm saying it, if we're just sending packages, we could send the common nipkg too.