ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Update CHM names to link to System Explorer pages #16

Closed Karl-G1 closed 4 years ago

Karl-G1 commented 4 years ago

What does this Pull Request accomplish?

Expose a boilerplate HTML help page for each of the template's System Explorer pages

Why should this Pull Request be merged?

Currently, the System Explorer pages have a section to display help, but every help link is broken.

What testing has been done?

Tested branch build and validated System Explorer shows the help content.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Build CHM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-16/2020-09-22/13%3A19%3A15/Build%20CHM.vi.png)
Communication Bus Template System Explorer.lvlib--Main Page.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-16/2020-09-22/13%3A19%3A15/Communication%20Bus%20Template%20System%20Explorer.lvlib--Main%20Page.vi.png)
LLB Pre-Build CHM Build.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-16/2020-09-22/13%3A19%3A15/LLB%20Pre-Build%20CHM%20Build.vi.png)
rtzoeller commented 4 years ago

Are any of these updates that should go into the wizard?

I think the .htm -> .html suffix change should be ported over.

Karl-G1 commented 4 years ago

Are any of these updates that should go into the wizard?

I need to see where the .html/.htm confusing came into play. It's likely that change needs to go into the wizard if it wasn't manually propogated. For the relative paths, that logic is now in the template. I think it went in very shortly after we generated the initial project for this repo.