search

ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Copy PPLs to Includes/ and the installed location on build #18

Closed rtzoeller closed 4 years ago

rtzoeller commented 4 years ago

What does this Pull Request accomplish?

Copy the built packed libraries directly to Includes/ and the installed location as a post-build step.

Enable building for Linux x64 as part of the automated builds.

Why should this Pull Request be merged?

This enables rebuilding only the PPLs when making most changes to the custom device, and also allows us to easily build for multiple targets with build.toml.

What testing has been done?

Built the PPLs and then the custom device, and confirmed I could use the custom device in VeriStand. I then modified the PPLs and rebuilt only them, and confirmed my changes were visible in VeriStand.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Copy PPLs to Includes.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-18/2020-09-28/10%3A24%3A25/Copy%20PPLs%20to%20Includes.vi.png)
Copy PPLs to NI VeriStand dir.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-18/2020-09-28/10%3A24%3A25/Copy%20PPLs%20to%20NI%20VeriStand%20dir.vi.png)
Post-Build Action.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-18/2020-09-28/10%3A24%3A25/Post-Build%20Action.vi.png)
niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Copy PPLs to Includes.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-18/2020-09-28/14%3A12%3A52/Copy%20PPLs%20to%20Includes.vi.png)
Copy PPLs to NI VeriStand dir.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-18/2020-09-28/14%3A12%3A52/Copy%20PPLs%20to%20NI%20VeriStand%20dir.vi.png)
Post-Build Action.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-18/2020-09-28/14%3A12%3A52/Post-Build%20Action.vi.png)
niphilj commented 4 years ago
rtzoeller commented 4 years ago

@niphilj Copy PPLs to NI VeriStand dir.vi is an almost exact copy of Copy .LLB to NI VeriStand dir.vi, which is auto-generated by the inline-async wizard. My assumption is that we might want to update this file with an automated tool down the road, so I tried to keep modifications to a minimum.

They are being changed when a person about to use the template generates a new instance of the custom device for their modifications. Is that correctly interpreted?

Mostly -- they're labeled in this way because the inline async wizard modifies them when generating the custom device. Since this "template" custom device was generated by that wizard, our output includes those quirks, although we aren't automatically updating them at this point in time.

I imagine that it's easier to just delete the unwanted files, but in some cases the copy is not fully atomic. If this poses a problem, you might want to just not copy them.

Any changes to Copy PPLs to NI VeriStand dir.vi should be mirrored in Copy .LLB to NI VeriStand dir.vi, and probably also updated upstream in the wizard.

If you want us to take on the work of upstreaming that change now, I can. Otherwise I'd prefer to match the existing behavior.