Move the engine implementation to the PPL

rtzoeller commented 4 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Move the core custom device engine implementation into the PPL.

Why should this Pull Request be merged?

With the engine in the LLB, we were seeing issues with the Inline Async API conflicting with other custom devices built with a different version of the API.

What testing has been done?

Confirmed the custom device still deploys.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Communication Bus Template.Async.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Communication%20Bus%20Template.Async.vi.png)

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Finalize Inline Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Finalize%20Inline%20Execution%20Units.vi.png)

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Initialize Inline Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Initialize%20Inline%20Execution%20Units.vi.png)

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Launch Asynchronous Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Launch%20Asynchronous%20Execution%20Units.vi.png)

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Read from Inline Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Read%20from%20Inline%20Execution%20Units.vi.png)

Communication Bus Template Engine.lvlib--Custom Device.lvlib--RT Driver VI.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--RT%20Driver%20VI.vi.png)

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Start Inline Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Start%20Inline%20Execution%20Units.vi.png)

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Unflatten Asynchronous Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Unflatten%20Asynchronous%20Execution%20Units.vi.png)

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Unflatten Compiled Data.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Unflatten%20Compiled%20Data.vi.png)

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Unflatten Inline Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Unflatten%20Inline%20Execution%20Units.vi.png)

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Write to Inline Execution Units.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Write%20to%20Inline%20Execution%20Units.vi.png)

Communication Bus Template Engine.lvlib--RT Driver VI.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Engine.lvlib--RT%20Driver%20VI.vi.png)

Communication Bus Template Shared.lvlib--Constants.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-23/2020-10-01/17%3A52%3A32/Communication%20Bus%20Template%20Shared.lvlib--Constants.vi.png)

rtzoeller commented 4 years ago

@buckd my suspicion is the search dialog is being caused by having multiple targets looking for the same PPL. I haven't confirmed that though.

buckd commented 4 years ago

@rtzoeller It's saved in the .lvproj file in Dependencies with the extra Execution Unit in the path, which is why it's searching. I'm just not sure why it doesn't get removed after loading the project.

ni / niveristand-communications-bus-template