ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Branch XNET implementation #25

Closed rtzoeller closed 4 years ago

rtzoeller commented 4 years ago

What does this Pull Request accomplish?

Modifies the custom device such that the XNET implementation can be used alongside the template implementation.

Why should this Pull Request be merged?

The changes here are being submitted to an xnet branch, which will contain an NI-XNET specific implementation of the template. The xnet branch should never be merged into main.

I am proposing that we do not squash merge this change, because the individual commit history here is potentially helpful.

What testing has been done?

Configured a system definition with both the XNET implementation and template implementation, and confirmed I could deploy them both concurrently and that I could alternate between their pages in System Explorer.

Additional information

Why are there still things with "Communication Bus Template" or "Communication Bus" in the name?

  1. I tried to keep this PR as small as possible to make it reviewable. Only things which needed to be renamed were renamed.
  2. I did not want to introduce unnecessary future merge conflicts. E.g. the PPLs have been renamed, but the top-level libraries in the PPLs have not been renamed, because renaming the lvlibs would force every VI to be re-saved.
  3. I would argue that most things with "Communication Bus [Template]" in the name should have the string omitted entirely, rather than replacing it. Just because the Custom Device Wizard inserted this string does not mean we need to perpetuate it -- especially if a user would be expected to manually update it.
niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Scripting.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/Communication%20Bus%20Template%20Scripting.lvlib--Constants.vi.png)
Copy .LLB to NI VeriStand dir.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/Copy%20.LLB%20to%20NI%20VeriStand%20dir.vi.png)
Copy PPLs to NI VeriStand dir.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/Copy%20PPLs%20to%20NI%20VeriStand%20dir.vi.png)
XNET Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20Engine.lvlib--RT%20Driver%20VI.vi.png)
XNET Shared.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20Shared.lvlib--Constants.vi.png)
XNET System Explorer.lvlib--ActionVIOnCompile.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20System%20Explorer.lvlib--ActionVIOnCompile.vi.png)
XNET System Explorer.lvlib--Compile Asynchronous Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20System%20Explorer.lvlib--Compile%20Asynchronous%20Execution%20Units.vi.png)
XNET System Explorer.lvlib--Compile Inline Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20System%20Explorer.lvlib--Compile%20Inline%20Execution%20Units.vi.png)
XNET System Explorer.lvlib--Export Configuration RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20System%20Explorer.lvlib--Export%20Configuration%20RTM.vi.png)
XNET System Explorer.lvlib--Get Item GUID.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20System%20Explorer.lvlib--Get%20Item%20GUID.vi.png)
XNET System Explorer.lvlib--Import Configuration RTM.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20System%20Explorer.lvlib--Import%20Configuration%20RTM.vi.png)
XNET System Explorer.lvlib--Initialization VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20System%20Explorer.lvlib--Initialization%20VI.vi.png)
XNET System Explorer.lvlib--Page Wrapper.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20System%20Explorer.lvlib--Page%20Wrapper.vi.png)
XNET System Explorer.lvlib--RunTimeMenu Custom Population.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20System%20Explorer.lvlib--RunTimeMenu%20Custom%20Population.vi.png)
XNET System Explorer.lvlib--RunTimeMenu Wrapper.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-25/2020-10-05/08%3A12%3A44/XNET%20System%20Explorer.lvlib--RunTimeMenu%20Wrapper.vi.png)