Closed buckd closed 4 years ago
It looks like you renamed build specs in the PPL project, but did not update their names in build.toml
.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
[x] This contribution adheres to CONTRIBUTING.md.
What does this Pull Request accomplish?
Modifies the custom device such that the Ballard ARINC 429 implementation can be used alongside the template implementation.
Why should this Pull Request be merged?
The changes here are being submitted to a
ballard_arinc_429
branch, which will contain a Ballard ARINC 429 specific implementation of the template. Theballard_arinc_429
branch should never be merged intomain
.I am proposing that we do not squash merge this change, because the individual commit history here is potentially helpful.
What testing has been done?
Configured a system definition with both the Ballard ARINC 429 implementation and template implementation, and confirmed I could deploy them both concurrently and that I could alternate between their pages in System Explorer.
Additional information
Why are there still things with "Communication Bus Template" or "Communication Bus" in the name?
The changes contained in the PR are based on the guide from #26. I have some updates to make to this document, but am putting this PR here for someone to test on a machine that is not mine to make sure there is nothing specific to my machine allowing this to work.