search

ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Don't discard errors when no execution units are specified #29

Closed rtzoeller closed 4 years ago

rtzoeller commented 4 years ago

What does this Pull Request accomplish?

Fix a bug where errors during initialization were discarded if at least one inline and one asynchronous execution unit were not specified.

Why should this Pull Request be merged?

Fixes a bug where errors are silently swallowed. This was a huge pain while debugging.

What testing has been done?

None - trivial change to terminals on loops.

rtzoeller commented 4 years ago

I'll cherry pick this into xnet after it gets submitted to main.

@buckd will probably want to cherry pick it into ballard_arinc_429 as well.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Engine.lvlib--Custom Device.lvlib--Unflatten Asynchronous Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-29/2020-10-06/21%3A27%3A28/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Unflatten%20Asynchronous%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--Custom Device.lvlib--Unflatten Inline Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-29/2020-10-06/21%3A27%3A28/Communication%20Bus%20Template%20Engine.lvlib--Custom%20Device.lvlib--Unflatten%20Inline%20Execution%20Units.vi.png)