User Story 1143866 CAN/XNET specific configurations options

[douglasnorman]

• [x] This contribution adheres to CONTRIBUTING.md.

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?

It updates Pages and RTMs with additional CAN options. It adds new scripting VIs to support these options. It adds new type defs to support these options.

Why should this Pull Request be merged?

To update System Explorer functionality for the engine work to integrate with.

What testing has been done?

The project has been built and System Explorer has been tested on my dev VM.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Scripting.lvlib--Add Port.vi.png


Communication Bus Template Scripting.lvlib--Constants.vi.png


Communication Bus Template Scripting.lvlib--Get Execution Mode.vi.png


Communication Bus Template Scripting.lvlib--Get Port CAN Cluster.vi.png


Communication Bus Template Scripting.lvlib--Get Port Interface Name.vi.png


Communication Bus Template Scripting.lvlib--Set Execution Mode.vi.png


Communication Bus Template Scripting.lvlib--Set Port CAN Cluster.vi.png


Communication Bus Template Scripting.lvlib--Set Port Interface Name.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Add Port RTM.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Frame.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Incoming.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Outgoing.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Port.vi.png


[rtzoeller]

Overall the changes look great. Just a few nitpicky things:

• [x] These should be moved into a subdirectory; possibly a new one for the incoming/outgoing sections? Be sure to move on disk as well.

• [x] The text color was changed inadvertently on the Port page. I don't know that we need this divider, but we shouldn't change the text color as part of this PR.

• [x] Should the cluster be visible on the port page?

• [x] I'd prefer if we used normal strings to persist data - rather than binary ones - unless there is a reason to do otherwise. It makes viewing the system definition as text much easier.

This also goes for the database name, although I'm guessing we'll want to also change that in the template. I'm fine with just fixing the cluster for now.

[niphilj]

To start, I agree with Ryan's comments and suggestions. And also nice work on this PR.

• [x] Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Port.vi In the Database Value Changed event case, is there a reason you're reading the New Value terminal instead of the control directly. I'm only asking because all the other Value Changed events are reading their terminals.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Scripting.lvlib--Add Port.vi.png


Communication Bus Template Scripting.lvlib--Constants.vi.png


Communication Bus Template Scripting.lvlib--Get Execution Mode.vi.png


Communication Bus Template Scripting.lvlib--Get Port CAN Cluster.vi.png


Communication Bus Template Scripting.lvlib--Get Port Interface Name.vi.png


Communication Bus Template Scripting.lvlib--Set Execution Mode.vi.png


Communication Bus Template Scripting.lvlib--Set Port CAN Cluster.vi.png


Communication Bus Template Scripting.lvlib--Set Port Interface Name.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Add Port RTM.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Frame.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Incoming.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Outgoing.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Port.vi.png


[douglasnorman]

Ryan, I made changes to address all your notes. Phil, I started reading New Value terminal in some other VIs, since that was their convention, so I just stuck with it.