Set and Get ECU for Frame page, and add Channel default values.

[douglasnorman]

• [x] This contribution adheres to CONTRIBUTING.md.

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?

1. It adds Set and Get for to show the ECU on the Frame page.
2. It adds the default value for channels.

Why should this Pull Request be merged?

This adds missing items we will want for database refresh.

What testing has been done?

I have built and tested on my dev VM.

[rtzoeller]

• [x] Get Frame ID.vi and Set Frame ID.vi now return/accept U32s, but the underlying storage type is still an I32. Change the storage type to match.

• [x] In Get ECU Frame Indices.vi, why do we need to get the default value for the signals (or the signals at all)? Can't we just search Frames for an element with the correct ID, and drop the inner for loop? This would solve the issue of this code being a duplicate of Read Frame Data.vi.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Scripting.lvlib--Constants.vi.png


Communication Bus Template Scripting.lvlib--Get Frame ECU.vi.png


Communication Bus Template Scripting.lvlib--Get Frame Id.vi.png


Communication Bus Template Scripting.lvlib--Set Frame ECU.vi.png


Communication Bus Template Scripting.lvlib--Set Frame Id.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Channel.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Frame.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Get ECU Frame Indices.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Import Frames RTM.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Read Database.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Read Frame Data.vi.png


[douglasnorman]

I fixed Get Frame ID.vi and Set Frame ID.vi. I was fixing the type mismatch, but didn't go far enough upstream.

Good idea on Get ECU Frame Indices.vi - the code is now much cleaner.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Scripting.lvlib--Constants.vi.png


Communication Bus Template Scripting.lvlib--Get Frame ECU.vi.png


Communication Bus Template Scripting.lvlib--Get Frame Id.vi.png


Communication Bus Template Scripting.lvlib--Set Frame ECU.vi.png


Communication Bus Template Scripting.lvlib--Set Frame Id.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Channel.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Frame.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Get ECU Frame Indices.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Import Frames RTM.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Read Database.vi.png


Communication Bus Template System Explorer.lvlib--Implementation.lvlib--Read Frame Data.vi.png


[niphilj]

• [x] Read Frame Data.vi We shouldn't need to be doing the building of the ID array inside the loop, and every time the outer loop runs. Pull it out to before the loop.

[douglasnorman]

Made Phil's suggested change to Get ECU Frame Indices.vi instead of Read Frame Data.vi :-)