Closed dbendele closed 3 years ago
Hey reviewers, let's discuss how this review might be broken up.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Reviewers, focus on encoding and decoding library and the tests added to verify functionality.
Feedback on the ARINC 429 base class and 32-bit Word child class is also welcome and appreciated. Most of the class VIs are accessor functions to write or read private class data. The purpose of the ARINC 429 32-bit Word class is to be able to build up an entire 32-bit word conforming to protocol and similarly read known fields/parameters from an input ARINC 429 word. The 32-Bit Word class depends on the encoding and decoding library included in this PR.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
[x] The error case of 32-bit Word.lvclass:Write Parameter to Word.vi
should be cleaned up.
[x] The error isn't passed through in 32-bit Word.lvclass:Read Parameters from Word.vi
.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
What does this Pull Request accomplish?
This PR adds a library for encoding and decoding DBL and integer data. This PR also adds a draft implementation class for writing and reading ARINC 429 32-bit words.
Why should this Pull Request be merged?
This functionality is required by the Ballard ARINC 429 use of the communications bus template.
What testing has been done?
mass compile and hand testing unit tests added for BCD and BNR encoding/decoding; all tests passing