Update protocol classes after enhancements to encoding and decoding libraries

[dbendele]

• [x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Adds abstract class for ARINC 429 and concrete class for ARINC 429 32-bit word. This concrete class provides accessors for 32-bit word properties including Label, SDI, Parameters, SSM, and Parity. Additionally. the 32-bit word can be written or read. Supported parameter (en/de)codings are BNR, BCD, and Discrete. The 32-bit class will be used in the implementation of the Ballard ARINC 429 custom device.

Why should this Pull Request be merged?

These classes encode and decode ARINC 429 32-bit words and can be used in Engine, System Explorer, and Scripting.

What testing has been done?

Local hand tests verify encoding and decoding of signed BNR and signed and unsigned BCD parameters. Automated unit tests for concrete 32-bit Word class implemented for positive and negative (signed) BNR parameters and for multiparameter word including BNR and BCD parameters.

[dbendele]

@rtzoeller and @buckd, this is the second installment of that monstrosity of a PR I submitted (temporarily) just before Thanksgiving. This PR focuses on the changes made within the 32-bit class to add functionality and to consume changes made in Encoding and Decoding reuse library.

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

32-bit Word.lvclass--Decode Parameter from U32.vi.png


32-bit Word.lvclass--Encode Parameter in U32.vi.png


32-bit Word.lvclass--Initialize.vi.png


32-bit Word.lvclass--Read Parameter from Word.vi.png


32-bit Word.lvclass--Read Parameters from Word.vi.png


32-bit Word.lvclass--Update Label.vi.png


32-bit Word.lvclass--Update Parameter.vi.png


32-bit Word.lvclass--Update SDI.vi.png


32-bit Word.lvclass--Update SSM.vi.png


32-bit Word.lvclass--Write Parameter to Word (U32).vi.png

.vi.png)

32-bit Word.lvclass--Write Parameter to Word.vi.png


32-bit Word.lvclass--Write Parameters to Word.vi.png


32-bit Word.lvclass--Write Parity Bit.vi.png


ARINC 429.lvclass--Read Parameter from Word.vi.png


ARINC 429.lvclass--Read Parameters from Word.vi.png


ARINC 429.lvclass--Update Label.vi.png


ARINC 429.lvclass--Write Parameter to Word.vi.png


ARINC 429.lvclass--Write Parameters to Word.vi.png


ARINC 429.lvclass--Write Parity Index.vi.png


Tests.lvclass--setUp.vi.png


Tests.lvclass--tearDown.vi.png


Tests.lvclass--test Multiparameter Datetime.vi.png


Tests.lvclass--test Negative (Signed) BNR Parameter.vi.png

%20BNR%20Parameter.vi.png)

Tests.lvclass--test Positive (Signed) BNR Parameter.vi.png

%20BNR%20Parameter.vi.png)

[dbendele]

Notes to reviewers

---

32-bit Word.lvclass--Initialize.vi

• Change shows up poorly in the diff png because an optional input 32-bit word was added

ARINC 429.lvclass

• VI inputs changed from recommended to required

ARINC 429.lvclass--Write Parity Index.vi

• Renamed VI. previous name 'Write Parity Start Index.vi'. input parity index is also required whereas it was previously recommended

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

32-bit Word.lvclass--Decode Parameter from U32.vi.png


32-bit Word.lvclass--Encode Parameter in U32.vi.png


32-bit Word.lvclass--Initialize.vi.png


32-bit Word.lvclass--Read Parameter from Word.vi.png


32-bit Word.lvclass--Read Parameters from Word.vi.png


32-bit Word.lvclass--Update Label.vi.png


32-bit Word.lvclass--Update Parameter.vi.png


32-bit Word.lvclass--Update SDI.vi.png


32-bit Word.lvclass--Update SSM.vi.png


32-bit Word.lvclass--Write Parameter to Word (U32).vi.png

.vi.png)

32-bit Word.lvclass--Write Parameter to Word.vi.png


32-bit Word.lvclass--Write Parameters to Word.vi.png


32-bit Word.lvclass--Write Parity Bit.vi.png


ARINC 429.lvclass--Read Parameter from Word.vi.png


ARINC 429.lvclass--Read Parameters from Word.vi.png


ARINC 429.lvclass--Read Parity Index.vi.png


ARINC 429.lvclass--Update Label.vi.png


ARINC 429.lvclass--Write Parameter to Word.vi.png


ARINC 429.lvclass--Write Parameters to Word.vi.png


ARINC 429.lvclass--Write Parity Index.vi.png


Tests.lvclass--setUp.vi.png


Tests.lvclass--tearDown.vi.png


Tests.lvclass--test Multiparameter Datetime.vi.png


Tests.lvclass--test Negative (Signed) BNR Parameter.vi.png

%20BNR%20Parameter.vi.png)

Tests.lvclass--test Positive (Signed) BNR Parameter.vi.png

%20BNR%20Parameter.vi.png)

[rtzoeller]

@dbendele feel free to merge after addressing the required items, and reviewing the optional feedback.

I love the diagram/Wikipedia example in the Multiparameter Datetime test.

Required Feedback

• [x] Update the pull request name to something other than the branch name.
• [x] Update the project settings to separate compiled code for new project items.

---

Optional Feedback

This VI isn't part of this PR, but I needed to look at it to understand the PR changes and therefore am including feedback for them.

• [ ] Encoding and Decoding.lvlib:Update Bit Field.vim can use the Assert Unsigned Integer Type.vim malleable provided by LabVIEW, instead of reimplementing it.

[dbendele]

Optional Feedback

This VI isn't part of this PR, but I needed to look at it to understand the PR changes and therefore am including feedback for them.

• [ ] Encoding and Decoding.lvlib:Update Bit Field.vim can use the Assert Unsigned Integer Type.vim malleable provided by LabVIEW, instead of reimplementing it.

will submit separate PR