Unique custom device build for cloning.

douglasnorman commented 3 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

The renamed source copy is now capable of being built into a unique custom device that runs in System Explorer.

Clone Template Main.vi calls all the subVIs needed to create the cloned source.
Copy Template Source to New Location.vi has been modified to save the CD name to a global.
Edit Paths in XML File.vi has been modified to use the CD name global.
Edit Project File Build Spec Destinations.vi has been added to edit the project to use the new CD name.
Edit VI Constants.vi has been modified to use the CD name global.
Remove Test Folder From lvproj Temporarily.vi has been added until we decide how to fix missing links to niveristand-custom-device-testing-tools.
Template Tool Global.vi has the addition of CD name.
Update CD Name in XML File.vi has been modified to use CD name. Please advise if we want to change National Instruments:: to NI:: at this point, or if we need to think about this more.

Why should this Pull Request be merged?

This completes the second user story for cloning the Comms Bus Template.

What testing has been done?

Testing on my dev VM includes:

Run Clone Template Main.vi to clone the source.
Build the two support build specifications by hand: Communication Bus Engine and Communication Bus System Explorer.
Build the two CD build specifications by hand: Configuration Release and Engine Release.
Confirm files get copied to C:\Users\Public\Documents\National Instruments\NI VeriStand 2020\Custom Devices.
Confirm the CD shows in System Explorer under Custom Devices>National Instruments and appears to function.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Template Tool.lvlib--Clone Template Main.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-73/2021-01-29/16%3A39%3A37/Template%20Tool.lvlib--Clone%20Template%20Main.vi.png)

Template Tool.lvlib--Copy Template Source to New Location.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-73/2021-01-29/16%3A39%3A37/Template%20Tool.lvlib--Copy%20Template%20Source%20to%20New%20Location.vi.png)

Template Tool.lvlib--Edit Paths in XML File.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-73/2021-01-29/16%3A39%3A37/Template%20Tool.lvlib--Edit%20Paths%20in%20XML%20File.vi.png)

Template Tool.lvlib--Edit Project File Build Spec Destinations.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-73/2021-01-29/16%3A39%3A37/Template%20Tool.lvlib--Edit%20Project%20File%20Build%20Spec%20Destinations.vi.png)

Template Tool.lvlib--Edit VI Constants.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-73/2021-01-29/16%3A39%3A37/Template%20Tool.lvlib--Edit%20VI%20Constants.vi.png)

Template Tool.lvlib--Remove Test Folder From lvproj Temporarily.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-73/2021-01-29/16%3A39%3A37/Template%20Tool.lvlib--Remove%20Test%20Folder%20From%20lvproj%20Temporarily.vi.png)

Template Tool.lvlib--Template Tool Global.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-73/2021-01-29/16%3A39%3A37/Template%20Tool.lvlib--Template%20Tool%20Global.vi.png)

Template Tool.lvlib--Update CD Name in XML File.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-73/2021-01-29/16%3A39%3A37/Template%20Tool.lvlib--Update%20CD%20Name%20in%20XML%20File.vi.png)

buckd commented 3 years ago

Why is the Tests folder being removed? It also claims to be "temporarily", but I don't see it added back.

douglasnorman commented 3 years ago

Why is the Tests folder being removed? It also claims to be "temporarily", but I don't see it added back.

It is temporary as in for this PR. The problem is the tests within link to niveristand-custom-device-testing-tools. Ryan mentioned to just remove them for now, since they are all broken.

ni / niveristand-communications-bus-template