search

ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Add typedefs for VeriStand channels and initialization VIs for BNR and Discrete parameters #76

Closed dbendele closed 3 years ago

dbendele commented 3 years ago

What does this Pull Request accomplish?

Adds more shared typedefs and two initialization VIs. These files depend on each other and the typedefs submitted with #74.

Why should this Pull Request be merged?

These typedefs and initialization VIs are used in the scripting code being tested and staged.

What testing has been done?

Verified that compiled code separated from source. Verified that each element of the cluster typedefs set in each of the initialization VIs.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Initialize Channel Parameter (BNR, Unsigned, Unity Scaling).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-76/2021-02-11/11%3A48%3A44/Initialize%20Channel%20Parameter%20(BNR%2C%20Unsigned%2C%20Unity%20Scaling).vi.png)
Initialize Channel Parameter (Discrete).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-76/2021-02-11/11%3A48%3A44/Initialize%20Channel%20Parameter%20(Discrete).vi.png)
buckd commented 3 years ago

I get a search dialog when loading the Initialization VIs. Is there some weird linking going on? image

dbendele commented 3 years ago

I get a search dialog when loading the Initialization VIs. Is there some weird linking going on?

It looks like the typedef is linked to the local git backup folder on my desktop. I will fix this and push.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Initialize Channel Parameter (BNR, Unsigned, Unity Scaling).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-76/2021-02-11/15%3A18%3A25/Initialize%20Channel%20Parameter%20(BNR%2C%20Unsigned%2C%20Unity%20Scaling).vi.png)
Initialize Channel Parameter (Discrete).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-76/2021-02-11/15%3A18%3A25/Initialize%20Channel%20Parameter%20(Discrete).vi.png)