ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Add scripting entry points to set parameter definition and default word #79

Closed dbendele closed 3 years ago

dbendele commented 3 years ago

What does this Pull Request accomplish?

Adds Set* functionality for parameter encoding and scaling and for default word to the scripting library.

Why should this Pull Request be merged?

Set Parameter Definition and other Set* functionality modifies existing parameters within the system definition. Set Default Word modifies the default word associated with an ARINC 429 label

What testing has been done?

New automated unit tests added for Get and Set pairs for parameter definitions and for default word. New and existing tests pass.

dbendele commented 3 years ago

@buckd, please confirm whether 'Default word' from the template is intended to replace 'WordInitialRawValue' from the released CD.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Scripting.lvlib--Set Default Word.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A38%3A08/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Default%20Word.vi.png)
Communication Bus Template Scripting.lvlib--Set Parameter Bit Encoding.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A38%3A08/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Parameter%20Bit%20Encoding.vi.png)
Communication Bus Template Scripting.lvlib--Set Parameter Definition.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A38%3A08/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Parameter%20Definition.vi.png)
Communication Bus Template Scripting.lvlib--Set Parameter Scaling.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A38%3A08/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Parameter%20Scaling.vi.png)
Scripting.lvclass--test Get-Set-Get Default Word Value.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A38%3A08/Scripting.lvclass--test%20Get-Set-Get%20Default%20Word%20Value.vi.png)
Scripting.lvclass--test Get-Set-Get Parameter Definitions.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A38%3A08/Scripting.lvclass--test%20Get-Set-Get%20Parameter%20Definitions.vi.png)
niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Scripting.lvlib--Set Default Word.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A57%3A51/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Default%20Word.vi.png)
Communication Bus Template Scripting.lvlib--Set Parameter Bit Encoding.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A57%3A51/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Parameter%20Bit%20Encoding.vi.png)
Communication Bus Template Scripting.lvlib--Set Parameter Definition.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A57%3A51/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Parameter%20Definition.vi.png)
Communication Bus Template Scripting.lvlib--Set Parameter Scaling.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A57%3A51/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Parameter%20Scaling.vi.png)
Scripting.lvclass--test Get-Set-Get Default Word Value.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A57%3A51/Scripting.lvclass--test%20Get-Set-Get%20Default%20Word%20Value.vi.png)
Scripting.lvclass--test Get-Set-Get Parameter Definitions.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/13%3A57%3A51/Scripting.lvclass--test%20Get-Set-Get%20Parameter%20Definitions.vi.png)
niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Scripting.lvlib--Set Default Word.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/19%3A35%3A59/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Default%20Word.vi.png)
Communication Bus Template Scripting.lvlib--Set Parameter Bit Encoding.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/19%3A35%3A59/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Parameter%20Bit%20Encoding.vi.png)
Communication Bus Template Scripting.lvlib--Set Parameter Definition.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/19%3A35%3A59/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Parameter%20Definition.vi.png)
Communication Bus Template Scripting.lvlib--Set Parameter Scaling.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/19%3A35%3A59/Communication%20Bus%20Template%20Scripting.lvlib--Set%20Parameter%20Scaling.vi.png)
Scripting.lvclass--test Get-Set-Get Default Word Value.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/19%3A35%3A59/Scripting.lvclass--test%20Get-Set-Get%20Default%20Word%20Value.vi.png)
Scripting.lvclass--test Get-Set-Get Parameter Definitions.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-79/2021-02-22/19%3A35%3A59/Scripting.lvclass--test%20Get-Set-Get%20Parameter%20Definitions.vi.png)