ni / niveristand-communications-bus-template

Template custom device for using communications buses in VeriStand
http://www.ni.com
MIT License
0 stars 3 forks source link

Handle a single inline execution unit #8

Closed rtzoeller closed 4 years ago

rtzoeller commented 4 years ago

What does this Pull Request accomplish?

Executes a single inline execution unit as part of the custom device engine.

Only supports running a single inline execution unit, using the default behavior provided by the interface.

Classes are manually flattened during compilation and unflattened during deployment, to work around bug 1131018.

Disables automated builds for non-Windows targets.

Why should this Pull Request be merged?

This partially unblocks execution unit development, and adds much of the scaffolding for future compilation and engine work.

What testing has been done?

I modified the default implementation of the interface to print to the system event log and deployed the custom device. The VIs were invoked as expected. Only tested on Windows, other OSes are expected to fail because of missing dependencies in the XML.

rtzoeller commented 4 years ago

Marking this as a draft until I can sort out the build.toml changes needed.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Engine.lvlib--Finalize Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/13%3A38%3A21/Communication%20Bus%20Template%20Engine.lvlib--Finalize%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--Initialize Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/13%3A38%3A21/Communication%20Bus%20Template%20Engine.lvlib--Initialize%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--Read from Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/13%3A38%3A21/Communication%20Bus%20Template%20Engine.lvlib--Read%20from%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/13%3A38%3A21/Communication%20Bus%20Template%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Communication Bus Template Engine.lvlib--Start Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/13%3A38%3A21/Communication%20Bus%20Template%20Engine.lvlib--Start%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--Unflatten Compiled Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/13%3A38%3A21/Communication%20Bus%20Template%20Engine.lvlib--Unflatten%20Compiled%20Data.vi.png)
Communication Bus Template Engine.lvlib--Write to Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/13%3A38%3A21/Communication%20Bus%20Template%20Engine.lvlib--Write%20to%20Execution%20Units.vi.png)
Communication Bus Template System Explorer.lvlib--ActionVIOnCompile.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/13%3A38%3A21/Communication%20Bus%20Template%20System%20Explorer.lvlib--ActionVIOnCompile.vi.png)
Communication Bus Template System Explorer.lvlib--Compile Data Refs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/13%3A38%3A21/Communication%20Bus%20Template%20System%20Explorer.lvlib--Compile%20Data%20Refs.vi.png)
niphilj commented 4 years ago
niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Engine.lvlib--Finalize Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/14%3A45%3A27/Communication%20Bus%20Template%20Engine.lvlib--Finalize%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--Initialize Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/14%3A45%3A27/Communication%20Bus%20Template%20Engine.lvlib--Initialize%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--Read from Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/14%3A45%3A27/Communication%20Bus%20Template%20Engine.lvlib--Read%20from%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/14%3A45%3A27/Communication%20Bus%20Template%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Communication Bus Template Engine.lvlib--Start Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/14%3A45%3A27/Communication%20Bus%20Template%20Engine.lvlib--Start%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--Unflatten Compiled Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/14%3A45%3A27/Communication%20Bus%20Template%20Engine.lvlib--Unflatten%20Compiled%20Data.vi.png)
Communication Bus Template Engine.lvlib--Write to Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/14%3A45%3A27/Communication%20Bus%20Template%20Engine.lvlib--Write%20to%20Execution%20Units.vi.png)
Communication Bus Template System Explorer.lvlib--ActionVIOnCompile.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/14%3A45%3A27/Communication%20Bus%20Template%20System%20Explorer.lvlib--ActionVIOnCompile.vi.png)
Communication Bus Template System Explorer.lvlib--Compile Data Refs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-10/14%3A45%3A27/Communication%20Bus%20Template%20System%20Explorer.lvlib--Compile%20Data%20Refs.vi.png)
rtzoeller commented 4 years ago

This project doesn't own either of those clusters, so making them type defs is out of scope for this PR. I agree that they probably should be.

niveristand-diff-bot commented 4 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Communication Bus Template Engine.lvlib--Finalize Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-11/09%3A27%3A47/Communication%20Bus%20Template%20Engine.lvlib--Finalize%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--Initialize Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-11/09%3A27%3A47/Communication%20Bus%20Template%20Engine.lvlib--Initialize%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--Read from Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-11/09%3A27%3A47/Communication%20Bus%20Template%20Engine.lvlib--Read%20from%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-11/09%3A27%3A47/Communication%20Bus%20Template%20Engine.lvlib--RT%20Driver%20VI.vi.png)
Communication Bus Template Engine.lvlib--Start Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-11/09%3A27%3A47/Communication%20Bus%20Template%20Engine.lvlib--Start%20Execution%20Units.vi.png)
Communication Bus Template Engine.lvlib--Unflatten Compiled Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-11/09%3A27%3A47/Communication%20Bus%20Template%20Engine.lvlib--Unflatten%20Compiled%20Data.vi.png)
Communication Bus Template Engine.lvlib--Write to Execution Units.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-11/09%3A27%3A47/Communication%20Bus%20Template%20Engine.lvlib--Write%20to%20Execution%20Units.vi.png)
Communication Bus Template System Explorer.lvlib--ActionVIOnCompile.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-11/09%3A27%3A47/Communication%20Bus%20Template%20System%20Explorer.lvlib--ActionVIOnCompile.vi.png)
Communication Bus Template System Explorer.lvlib--Compile Data Refs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-8/2020-09-11/09%3A27%3A47/Communication%20Bus%20Template%20System%20Explorer.lvlib--Compile%20Data%20Refs.vi.png)