Cloning - Help files build and work.

douglasnorman commented 3 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

This fixes a couple of help bugs:

It removes renaming the "existing" chm and hhp files, because they don't actually exist in the source code. They were in my source due to a build I did at one point.
It edits the CD_CHM_FileName string constant in each Page VI to match the new clone name.

Edited files:

Clone Template Main.vi -1. Added Edit Page VIs Help CHM Constant case to change the string constant in each VI. -2. Removed Rename Help Files.vi from the Update Help Files case. -3. Bonus - changed the selection mode to Folders for the Enter Destination Directory path control.
Edit VI Constants.vi was renamed to Edit VI String Constant.vi and now has the string label as an input. This is to make it more generic, so it could be used to edit the Page VIs.
Rename Help Files.vi was deleted, because there are no files in source to rename.
Consumer State.ctl has an additional item: Edit Page VIs Help CHM Constant.
Queue Cluster.ctl contains Consumer State.ctl.

Why should this Pull Request be merged?

This will mean that Help is no longer broken in System Explorer.

What testing has been done?

Testing on my dev VM includes:

Run Clone Template Main.vi to clone the source, and confirm Help works in System Explorer.
Run Clone Template Main.vi to clone the source to a non-default folder, and confirm Help works in System Explorer.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Template Tool.lvlib--Clone Template Main.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-85/2021-03-03/14%3A13%3A10/Template%20Tool.lvlib--Clone%20Template%20Main.vi.png)

Template Tool.lvlib--Edit VI String Constant.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-85/2021-03-03/14%3A13%3A10/Template%20Tool.lvlib--Edit%20VI%20String%20Constant.vi.png)

buckd commented 3 years ago

I continually get a crash during Replace Project PPLs.

douglasnorman commented 3 years ago

Latest change affects Init case.

niveristand-diff-bot commented 3 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Template Tool.lvlib--Clone Template Main.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-85/2021-03-04/10%3A43%3A30/Template%20Tool.lvlib--Clone%20Template%20Main.vi.png)

Template Tool.lvlib--Edit VI String Constant.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-communications-bus-template/PR-85/2021-03-04/10%3A43%3A30/Template%20Tool.lvlib--Edit%20VI%20String%20Constant.vi.png)

ni / niveristand-communications-bus-template