ni / niveristand-custom-device-build-tools

Tools for automating builds of NI VeriStand custom devices.
MIT License
18 stars 28 forks source link

Make diff timeout configurable #127

Closed buckd closed 2 years ago

buckd commented 2 years ago

What does this Pull Request accomplish?

Enables a calling Jenkinsfile to configure the timeout for running the LabVIEW diff.

Why should this Pull Request be merged?

Some diffs take longer than the default 60 minutes to complete. This change allows the user to configure a timeout such that the diff will finish.

Note: I didn't just increase the default value because, in many cases, a diff that takes longer than an hour begins to become too complex to be useful as just a visual diff in github. In those cases, I don't want to wait longer than the default time before the diff step ends.

What testing has been done?

Ran a replay of a PR build with the new file and a timeout of 120 minutes set. The build log file indicates the timeout will be "2 hr 0 min".