search

ni / niveristand-custom-device-build-tools

Tools for automating builds of NI VeriStand custom devices.
MIT License
18 stars 28 forks source link

Limit diffs to 60 VIs to avoid timeout #177

Closed Karl-G1 closed 1 year ago

Karl-G1 commented 1 year ago

What does this Pull Request accomplish?

Do not run diff logic if more than 60 VIs were modified in a PR Use the PR branch for the copy of the repo cloned during the diff step to validate logic when making changes

Why should this Pull Request be merged?

Diffs take roughly 1 minute each, and the Azure pipeline will timeout after an hour. To avoid needlessly using build node time for a step that will eventually fail, simply do not diff any VIs if more than 60 were modified.

What testing has been done?

Mass compiling the LV operations source to 2020 to touch ~70 VIs for a draft PR build.

niveristand-diff-bot commented 1 year ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

The following VIs could not be diffed: