search

ni / niveristand-custom-device-build-tools

Tools for automating builds of NI VeriStand custom devices.
MIT License
18 stars 28 forks source link

add check for empty file count in nipkg #181

Closed papowerNI closed 1 year ago

papowerNI commented 1 year ago

What does this Pull Request accomplish?

Fails verification if package files have no files in them, now that we are checking anyway. Also updates a regex to use the literal period instead of a wildcard to avoid unexpected failures with certain branch names

Why should this Pull Request be merged?

Packages should never be empty, so we might as well catch the error case. Also fixes a bug that would impact any dev branch with "nipkg" in the name

What testing has been done?

Tested with dev tools, which was making empty packages at the time of the test: image

This PR should not fail, to verify the existing case.

rtzoeller commented 1 year ago

Packages should never be empty

Is this for just the data.tar.gz section? Or entirely empty?

It's valid to have a package with a control file but no payload.

rtzoeller commented 1 year ago

Talked offline, @papowerNI is going to add a flag to disable that check for virtual packages.

papowerNI commented 1 year ago

merge did something weird so I'm just going to remake this