Enable error reporting on diff pipeline

ni / niveristand-custom-device-build-tools

Tools for automating builds of NI VeriStand custom devices.

MIT License

18 stars 28 forks source link

Enable error reporting on diff pipeline #193

Open Karl-G1 opened 1 year ago

Karl-G1 commented 1 year ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

This PR is an attempt to fail the build when the diff pipeline errors out.

Why should this Pull Request be merged?

PR #192 build succeeded but should have failed with git_utilities.py was deleted.

What testing has been done?

Pending PR build

buckd commented 1 year ago

This failed for the intended reason, but also would have failed because an error was reported due to pip not being the latest version. I'd like to see the result of a build without git_utilities.py removed and see if the diff stage passes then. I know we also see errors returned during diff when we try to close LabVIEW if it's already been closed. That should be ignorable, but might cause the build to fail with this change.

niveristand-diff-bot commented 1 year ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

ClearCache.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/ni/niveristand-custom-device-build-tools/PR-193/2023-06-08/15%3A46%3A09/ClearCache.vi.png)