Add pool and demands to packaging step to ensure specific agents

jmartinez44 commented 2 months ago

[X] This contribution adheres to CONTRIBUTING.md.

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?

This change ensure that the packaging job uses an agent from the desired pool and with the desired capability similar to others steps in the stages.yml file.

Why should this Pull Request be merged?

The lack of a pool and demands section in the packaging job open up the step to running on a undesired agent when specifying a pool other than DevCentral-VeriStand-CustomDevices. Specifically, the ADG System R&D team uses their own pool of agents and were encountering an issue where the packaging job would choose an agent other than the ones they'd like to use that are in the same pool but not owned by our team. This fixes the issue while retaining the expected behavior when the VeriStand team runs this build tool on their agent pool.

What testing has been done?

I forked the build tools repo and made these changes to it, ran a custom device build pipeline using that fork, and the run was successful. Here is the link: https://dev.azure.com/ni/DevCentral/_build/results?buildId=9537391&view=results

buckd commented 2 months ago

/AzurePipelines run ni.niveristand-custom-device-build-tools

azure-pipelines[bot] commented 2 months ago

Azure Pipelines successfully started running 1 pipeline(s).

buckd commented 2 months ago

@papowerNI Are you good with this change or should we try to have something like an optional "extra demands" parameter that we append to the constant demands in the template?

papowerNI commented 2 months ago

yes this is just adding existing behavior to the package job that already exists for the other jobs in stages.yaml that zoeller added back in October, I think it makes sense.

ni / niveristand-custom-device-build-tools