Simplify BCD Decode to remove duplicate data path

ni / niveristand-custom-device-development-tools

LabVIEW VIs providing common functionality used by multiple VeriStand custom devices.

MIT License

18 stars 9 forks source link

Simplify BCD Decode to remove duplicate data path #56

Closed buckd closed 2 years ago

buckd commented 2 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Remove extra call to BCD Decode Integer.vim that is not needed.

Why should this Pull Request be merged?

The existing extra call, in some situations, causes massive overhead when used by asynchronous custom devices. This change removes that overhead.

What testing has been done?

Ran all unit tests and tested execution time in the AIM ARINC 429 custom device when Rx is inlined and async. Difference is ~10 us instead of ~400 us.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

The following VIs could not be diffed:

C:\jenkins\workspace\m-device-development-tools_PR-56\encoding-decoding\Source\BCD Decode.vim

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Encoding and Decoding.lvlib--BCD Decode.vim.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-development-tools/PR-56/2022-07-20/11%3A26%3A32/Encoding%20and%20Decoding.lvlib--BCD%20Decode.vim.png)