Use polling read when testing loopback with new tolerance input

Karl-G1 commented 2 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Add a Tolerance input to the polling read's value check in Read Rx Values Until Equal.vi to line up with VI tester's default behavior when comparing array elements.
Use polling reads in the 'Assert...' loopback test VIs by using Write Tx Values and Read Rx Values Until Equal.vi instead of a hard-coded delay.

Why should this Pull Request be merged?

Allows polling value check (in Read Rx Values Until Equal.vi) to be used for analog loopback tests. Without a tolerance, the double values for an AO-AI loopback will never be perfectly equal.
Increases test stability by polling with a longer timeout during system tests while achieving lower overall test time due to the polling reads.

What testing has been done?

Validated a DAQ system test using AO-AI loopback passes with this implementation.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

VeriStandTestUtilities.lvlib--Read Rx Values Until Equal.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/12%3A28%3A27/VeriStandTestUtilities.lvlib--Read%20Rx%20Values%20Until%20Equal.vi.png)

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

VeriStandTestCase.lvclass--AssertChannelLoopback.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/13%3A41%3A43/VeriStandTestCase.lvclass--AssertChannelLoopback.vi.png)

VeriStandTestCase.lvclass--AssertMultiChannelLoopback.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/13%3A41%3A43/VeriStandTestCase.lvclass--AssertMultiChannelLoopback.vi.png)

VeriStandTestCase.lvclass--AssertMultiChannelLoopbackForMappedChannels.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/13%3A41%3A43/VeriStandTestCase.lvclass--AssertMultiChannelLoopbackForMappedChannels.vi.png)

VeriStandTestUtilities.lvlib--Read Rx Values Until Equal.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/13%3A41%3A43/VeriStandTestUtilities.lvlib--Read%20Rx%20Values%20Until%20Equal.vi.png)

VeriStandTestUtilities.lvlib--Write Tx Values and Read Rx Values Until Equal.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/13%3A41%3A43/VeriStandTestUtilities.lvlib--Write%20Tx%20Values%20and%20Read%20Rx%20Values%20Until%20Equal.vi.png)

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

VeriStandTestCase.lvclass--AssertChannelLoopback.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/14%3A03%3A08/VeriStandTestCase.lvclass--AssertChannelLoopback.vi.png)

VeriStandTestCase.lvclass--AssertMultiChannelLoopback.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/14%3A03%3A08/VeriStandTestCase.lvclass--AssertMultiChannelLoopback.vi.png)

VeriStandTestCase.lvclass--AssertMultiChannelLoopbackForMappedChannels.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/14%3A03%3A08/VeriStandTestCase.lvclass--AssertMultiChannelLoopbackForMappedChannels.vi.png)

VeriStandTestUtilities.lvlib--Read Rx Values Until Equal.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/14%3A03%3A08/VeriStandTestUtilities.lvlib--Read%20Rx%20Values%20Until%20Equal.vi.png)

VeriStandTestUtilities.lvlib--Write Tx Values and Read Rx Values Until Equal.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/14%3A03%3A08/VeriStandTestUtilities.lvlib--Write%20Tx%20Values%20and%20Read%20Rx%20Values%20Until%20Equal.vi.png)

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

VeriStandTestCase.lvclass--AssertChannelLoopback.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/15%3A24%3A42/VeriStandTestCase.lvclass--AssertChannelLoopback.vi.png)

VeriStandTestCase.lvclass--AssertMultiChannelLoopback.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/15%3A24%3A42/VeriStandTestCase.lvclass--AssertMultiChannelLoopback.vi.png)

VeriStandTestCase.lvclass--AssertMultiChannelLoopbackForMappedChannels.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/15%3A24%3A42/VeriStandTestCase.lvclass--AssertMultiChannelLoopbackForMappedChannels.vi.png)

VeriStandTestUtilities.lvlib--Read Rx Values Until Equal.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/15%3A24%3A42/VeriStandTestUtilities.lvlib--Read%20Rx%20Values%20Until%20Equal.vi.png)

VeriStandTestUtilities.lvlib--Write Tx Values and Read Rx Values Until Equal.vi.png

![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-custom-device-testing-tools/PR-72/2022-03-31/15%3A24%3A42/VeriStandTestUtilities.lvlib--Write%20Tx%20Values%20and%20Read%20Rx%20Values%20Until%20Equal.vi.png)

ni / niveristand-custom-device-testing-tools